Review 13.4 Merged

86843[TASK] Transform FormEngineValidation into a TypeScript class

Andreas Kienast CR +2 V +2 Normal +59 −68 updated 10/31/24, 09:17

Commit message

This introduces complete types for all methods provided by
`FormEngineValidation` and thereby enables working type-checks
and auto-completion.

The one necessary change caused by a wrong return-type-usage is fixed
in a related change.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 57

  1. Andreas Kienast uploaded patch set 1 10/31/24, 08:29

  2. core-ci voted on patch set 1 V -1 10/31/24, 08:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68895

  3. Andreas Kienast uploaded patch set 2 V -1 10/31/24, 09:03

  4. core-ci voted on patch set 2 V +1 10/31/24, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68898

  5. Andreas Kienast voted on patch set 2 CR +2 V +2 10/31/24, 09:12

  6. Andreas Kienast merged patch set 3 10/31/24, 09:12

  7. Oliver Hader voted on patch set 3 CR +1 10/31/24, 09:17