Review main Merged

86844[BUGFIX] Add missing label for TsConfig provided by site

Georg Ringer CR +2 V +2 Easy +3 −0 updated 10/31/24, 17:12

Commit message

Provide the missing translation of a badge which is shown
for TsConfig provided by a site.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2632

Show 67 earlier messages
  1. Georg Ringer uploaded patch set 1 10/31/24, 08:52

  2. Georg Ringer commented on patch set 1 10/31/24, 08:52

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 10/31/24, 08:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68897

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 10/31/24, 11:55

  5. Andreas Kienast commented on patch set 1 CR -1 10/31/24, 12:54

    This looks broken
  6. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 10/31/24, 13:17

  7. Garvin Hicking updated the commit message in patch set 3 10/31/24, 13:19

  1. Garvin Hicking commented on patch set 3 10/31/24, 13:19

    Indeed. Unsure though if bugfix or better task?

    Reply

    Indeed, looked up the issue number and linked, also adjusted wrong 13.3 relation. Also maybe label this as Task instead of Bugfix? Doesn't break functionality currently.
  2. core-ci voted on patch set 2 V +1 10/31/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68922

  3. core-ci voted on patch set 3 V +1 10/31/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68923

  4. Andreas Kienast commented on patch set 3 10/31/24, 13:28

    Reply

    Well, the linked issue mentions that the label is missing, leading to a glitching UI. Sounds pretty buggy to me ;)
  5. Andreas Kienast updated the commit message in patch set 4 V +1 10/31/24, 13:29

  6. Andreas Kienast commented on patch set 4 CR +1 V +1 10/31/24, 13:30

    Reply

    Done
  7. core-ci voted on patch set 4 V +1 10/31/24, 13:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68924

  8. Garvin Hicking commented on patch set 4 CR +1 V +1 10/31/24, 13:56

    Reply

    Done
  9. Garvin Hicking voted on patch set 4 CR +2 V +2 10/31/24, 13:56

  10. Garvin Hicking updated the commit message in patch set 5 CR +1 V +1 10/31/24, 13:57

  11. Garvin Hicking commented on patch set 5 CR +1 V +1 10/31/24, 13:57

    Had to remove "12.4" from releases, Site settings do not exist there ^^
  12. Garvin Hicking updated the commit message in patch set 6 CR +1 V +1 10/31/24, 13:59

  13. Andreas Kienast voted on patch set 6 CR +1 V +1 10/31/24, 14:00

  14. Garvin Hicking commented on patch set 6 10/31/24, 14:00

    My bad, confused this with site set settings. This applies to v12. (Sidebar: Is there a 'site set settings' xlf key needed, too?)
  15. Sébastien Delcroix commented on patch set 5 10/31/24, 14:02

    Reply

    @gh@faktor-e.de Hi Garvin, there are settings in settings.yaml ;)
  16. Garvin Hicking commented on patch set 6 10/31/24, 14:03

    Reply

    Acknowledged
  17. Sébastien Delcroix commented on patch set 6 10/31/24, 14:03

    Reply

    Found this issue on this version
  18. Sébastien Delcroix commented on patch set 6 10/31/24, 14:05

    Reply

    Done
  19. core-ci voted on patch set 5 V +1 10/31/24, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68926

  20. core-ci voted on patch set 6 V +1 10/31/24, 14:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68928

  21. Garvin Hicking voted on patch set 6 CR +1 V +1 10/31/24, 14:30

  22. Simon Schaufelberger voted on patch set 6 CR +1 V +1 10/31/24, 15:22

  23. Benjamin Franzke voted on patch set 6 CR +1 V +1 10/31/24, 17:04

  24. Benjamin Franzke voted on patch set 6 CR +2 V +2 10/31/24, 17:12

  25. Benjamin Franzke merged patch set 7 10/31/24, 17:12