Review 13.4 Merged

86845[BUGFIX] Initialize FormEngine review module before validation takes place

Andreas Kienast CR +2 V +2 Normal +27 −25 updated 10/31/24, 11:24

Commit message

In order to solve initialization race conditions with the module
`@typo3/backend/form-engine-review`, the module is not initialized
anymore on load.
The module is now explicitly instantiated in the validation
module and gets the form element passed as constructor argument, all
before initial validation is executed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Andreas Kienast uploaded patch set 1 10/31/24, 10:54

  2. core-ci voted on patch set 1 V -1 10/31/24, 11:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68906

  3. Andreas Kienast uploaded patch set 2 V -1 10/31/24, 11:16

  4. core-ci voted on patch set 2 V +1 10/31/24, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68909

  5. Andreas Kienast voted on patch set 2 CR +2 V +2 10/31/24, 11:24

  6. Andreas Kienast merged patch set 3 10/31/24, 11:24