Review 12.4 Merged

86864[BUGFIX] Reference correct time fields in cache calculation

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 11/04/24, 09:48

Commit message

The method `CacheLifetimeCalculator::getFirstTimeValueForRecord()`
collects the configured time fields (starttime, endtime) by their actual
field names, which can be different, depending on the TCA.

However, when calculating the value the TCA setting names were used as
field names, which happens to always match within the TYPO3 Core, but
may not in 3rd party extensions.

The method is fixed to use the correct field names to access record
properties.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Andreas Kienast commented on patch set 1 11/04/24, 09:40

    Cherry Picked from branch 13.4.
  2. core-ci voted on patch set 1 V +1 11/04/24, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69023

  3. Andreas Kienast voted on patch set 1 CR +2 V +2 11/04/24, 09:48

  4. Andreas Kienast merged patch set 2 11/04/24, 09:48