Review main Merged

86874[BUGFIX] Properly enable 'translationOption' for all validators

Jörg Hofrichter CR +2 V +2 Easy +13 −0 updated 11/03/24, 09:54

Commit message

Make sure the translationOptions are actually applied by the
following validators:

- FileSizeValidator
- ImageDimensionsValidator
- MimeTypeValidator

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 812

  1. Jörg Hofrichter uploaded patch set 1 11/02/24, 20:49

  2. core-ci voted on patch set 1 V -1 11/02/24, 20:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68979

  3. Jörg Hofrichter uploaded patch set 2 V -1 11/02/24, 20:57

  4. core-ci voted on patch set 2 V +1 11/02/24, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68980

  5. Jörg Hofrichter updated the commit message in patch set 3 V +1 11/02/24, 21:05

  6. core-ci voted on patch set 3 V +1 11/02/24, 21:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68981

  7. Garvin Hicking updated the commit message in patch set 4 V +1 11/02/24, 21:15

  8. Garvin Hicking commented on patch set 4 CR +1 11/02/24, 21:16

    Thanks so much for getting on it quickly, looking good! 👍
  9. core-ci voted on patch set 4 V +1 11/02/24, 21:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/68982

  10. Torben Hansen commented on patch set 4 CR +1 V +1 11/03/24, 05:43

    Thanks a lot 👍
  11. Garvin Hicking voted on patch set 4 CR +2 V +2 11/03/24, 08:40

  12. Garvin Hicking merged patch set 5 11/03/24, 09:54