Review main Merged

86876[TASK] Add note on removal of FileRepository->findFileReferenceByUid()

TYPO3com CR +2 V +2 Easy +32 −0 updated 11/04/24, 20:20

Commit message

FileRepository->findFileReferenceByUid() has been removed and was
not yet mentioned in the changelog entry.

Also, the extension scanner has been adapted to find this usage.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Garvin Hicking +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1116

  1. TYPO3com uploaded patch set 1 11/04/24, 09:32

  2. core-ci voted on patch set 1 V +1 11/04/24, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69021

  3. Simon Schaufelberger commented on patch set 1 11/04/24, 11:14

    Breaking-101948-FileBasedAbstractRepositoryClassRemoved.rst:45

    whitespace at eol
  4. Garvin Hicking commented on patch set 2 V +1 11/04/24, 15:57

    Published edit on patch set 1.
  5. Garvin Hicking commented on patch set 2 11/04/24, 15:57

    Breaking-101948-FileBasedAbstractRepositoryClassRemoved.rst:45 Reply

    Done
  6. Garvin Hicking updated the commit message in patch set 3 11/04/24, 15:58

  7. core-ci voted on patch set 2 V +1 11/04/24, 16:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69043

  8. core-ci voted on patch set 3 V +1 11/04/24, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69044

  9. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/04/24, 16:11

  10. Garvin Hicking commented on patch set 3 CR -1 11/04/24, 16:15

    Benni metioned to add a Scanner matcher entry for this specific removed class. Will try to do that.
  11. Garvin Hicking uploaded patch set 4 CR +1 V +1 11/04/24, 16:27

    Add code scanner
  12. Garvin Hicking voted on patch set 4 CR +1 V +1 11/04/24, 16:28

  13. core-ci voted on patch set 4 V +1 11/04/24, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69045

  14. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/04/24, 16:45

  15. Benni Mack voted on patch set 4 CR +2 V +2 11/04/24, 20:20

  16. Benni Mack merged patch set 5 11/04/24, 20:20