Review main Merged

86878[BUGFIX] Apply InnoDB as default to CREATE TABLE options

Benjamin Franzke CR +2 V +2 Hard +260 −40 updated 11/07/24, 11:46

Commit message

Our database schema relies on InnoDB for certain indexes.
The entry_identifier key size of the sys_registry is 1024
(`(128 + 128) * 4 = 1024`) when using a 4-byte utf8mb4 charset,
which exceeds the MySQL MyISAM limit of 1000 bytes per key.

Ensure that we apply InnoDB as a default for all tables (instead
of defining it explicitly for only some table and therefore miss
relevant ones).

Ensure we also create migrations to switch tables to InnoDB that do
not explicitly list ENGINE=MyISAM in their table options.

Also default to ROW_FORMAT=Dynamic to ensure existing
`ENGINE=MyISAM ROW_FORMAT=Fixed` tables can be switched to InnoDB
which does not support ROW_FORMAT=Fixed in strict mode.

See https://dev.mysql.com/doc/refman/5.7/en/create-table.html:
> For InnoDB tables:
> * …
> * ROW_FORMAT=FIXED is not supported. If ROW_FORMAT=FIXED is specified
>   while innodb_strict_mode is disabled, InnoDB issues a warning and
>   assumes ROW_FORMAT=DYNAMIC. If ROW_FORMAT=FIXED is specified while
>   innodb_strict_mode is enabled, which is the default, InnoDB returns
>   an error.

The AboutDatabaseErrorRowSizeTooLarge is updated to reflect this change.
The previous section that describe these actions as manual checks have
been removed in order to reduce the amount of manual maintenance that an
integrator has to perform for a TYPO3 update.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 21

Show 1 more file

Review log 2027

Show 12 earlier messages
  1. Benjamin Franzke uploaded patch set 1 11/04/24, 18:08

  2. core-ci voted on patch set 1 V -1 11/04/24, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69048

  1. Benjamin Franzke uploaded patch set 2 V -1 11/04/24, 18:27

  2. core-ci voted on patch set 2 V -1 11/04/24, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69050

  3. Benjamin Franzke marked it work in progress 11/04/24, 18:42

  4. Benjamin Franzke voted on patch set 2 CR -1 11/04/24, 18:42

  5. Benjamin Franzke uploaded patch set 3 CR -1 V -1 11/04/24, 19:16

  6. core-ci voted on patch set 3 V +1 11/04/24, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69051

  7. Benjamin Franzke updated the commit message in patch set 4 V +1 11/04/24, 19:29

  8. core-ci voted on patch set 4 V +1 11/04/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69052

  9. Benjamin Franzke uploaded patch set 5 V +1 11/04/24, 21:43

  10. core-ci voted on patch set 5 V -1 11/04/24, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69058

  11. Benjamin Franzke uploaded patch set 6 V -1 11/04/24, 21:53

  12. core-ci voted on patch set 6 V +1 11/04/24, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69059

  13. Andreas Kienast voted on patch set 6 CR +1 11/05/24, 15:31

  14. Stefan Bürk commented on patch set 6 CR -1 11/06/24, 07:49

    -1 -> reviewing ...
  15. Stefan Bürk commented on patch set 6 CR +1 11/06/24, 08:37

    Reply

    Done
  16. Stefan Bürk voted on patch set 6 V +1 11/06/24, 08:42

  17. Andreas Kienast voted on patch set 6 V +1 11/06/24, 11:10

  18. Benjamin Franzke commented on patch set 6 CR -1 11/06/24, 12:22

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:104

    I just figured that this paragraph needs to be updated, as it implies the availability of the removed paragraphs. I'll try to rephrase this to make clear that InnoDB/RowFormat=Dynamic is a requirement for further error-analysis and that these are to be updated via Database Analyzer.
  19. Benjamin Franzke uploaded patch set 7 CR +1 V +1 11/07/24, 10:51

  20. Benjamin Franzke commented on patch set 7 11/07/24, 10:51

    Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:104 Reply

    I decided to not drop the paragraphs for now, as the documentation will be available immediately and then users are "lost" until 13.4.1 is released. Also Garvin mentioned it's a bit of a pity if the information is just lost. So I let that be a "for later" task to reducde this and instead added on-top information that InnoDB and ROW_FORMAT are now migrated by the Database Analyzer. Please check and revote 😊
  21. Andreas Kienast voted on patch set 7 CR +1 V +1 11/07/24, 10:53

  22. core-ci voted on patch set 7 V +1 11/07/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69177

  23. Stefan Bürk voted on patch set 7 CR +1 V +1 11/07/24, 11:35

  24. Benjamin Franzke voted on patch set 7 CR +2 V +2 11/07/24, 11:36

  25. Benjamin Franzke merged patch set 8 11/07/24, 11:46