86878[BUGFIX] Apply InnoDB as default to CREATE TABLE options
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 2
Files 21
- typo3/sysext/core/Classes/Database/Platform/Traits/MySQLCompatibleAlterTablePlatformAwareTrait.php+23 −2
- typo3/sysext/core/Classes/Database/Schema/ConnectionMigrator.php+16 −0
- typo3/sysext/core/Classes/Database/ConnectionPool.php+0 −3
- typo3/sysext/core/Documentation/Changelog/13.2/Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst2+25 −12
- typo3/sysext/core/Resources/Private/Sql/Cache/Backend/Typo3DatabaseBackendCache.sql+1 −1
- typo3/sysext/core/Resources/Private/Sql/Cache/Backend/Typo3DatabaseBackendTags.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/changeExistingIndex.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/connectionTestTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/enumTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/mediumTextTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/mediumTextTable_changeToLongText.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newLargeTable.sqlnew+13 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newLargeTableWithMyISAMFixed.sqlnew+13 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTableInnoDB.sqlnew+11 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/newTableMyISAM.sqlnew+11 −0
- typo3/sysext/core/Tests/Functional/Database/Fixtures/setTable.sql+1 −1
- typo3/sysext/core/Tests/Functional/Database/Schema/SchemaMigratorTest.php+126 −1
- typo3/sysext/core/ext_tables.sql+5 −5
- typo3/sysext/frontend/ext_tables.sql+1 −1
Show 1 more file
Review log 2027
Show 12 earlier messages
-
Benjamin Franzke uploaded patch set 1 11/04/24, 18:08
-
core-ci voted on patch set 1 V -1 11/04/24, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69048
-
Benjamin Franzke uploaded patch set 2
V -111/04/24, 18:27 -
core-ci voted on patch set 2 V -1 11/04/24, 18:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69050
-
Benjamin Franzke marked it work in progress 11/04/24, 18:42
-
Benjamin Franzke voted on patch set 2 CR -1 11/04/24, 18:42
-
Benjamin Franzke uploaded patch set 3
CR -1V -111/04/24, 19:16 -
core-ci voted on patch set 3 V +1 11/04/24, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69051
-
Benjamin Franzke updated the commit message in patch set 4
V +111/04/24, 19:29 -
core-ci voted on patch set 4 V +1 11/04/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69052
-
Benjamin Franzke uploaded patch set 5
V +111/04/24, 21:43 -
core-ci voted on patch set 5 V -1 11/04/24, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69058
-
Benjamin Franzke uploaded patch set 6
V -111/04/24, 21:53 -
core-ci voted on patch set 6 V +1 11/04/24, 22:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69059
-
Andreas Kienast voted on patch set 6 CR +1 11/05/24, 15:31
-
Stefan Bürk commented on patch set 6 CR -1 11/06/24, 07:49
-1 -> reviewing ... -
Stefan Bürk commented on patch set 6 CR +1 11/06/24, 08:37
Reply
Done -
Stefan Bürk voted on patch set 6 V +1 11/06/24, 08:42
-
Andreas Kienast voted on patch set 6 V +1 11/06/24, 11:10
-
Benjamin Franzke commented on patch set 6 CR -1 11/06/24, 12:22
Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:104I just figured that this paragraph needs to be updated, as it implies the availability of the removed paragraphs. I'll try to rephrase this to make clear that InnoDB/RowFormat=Dynamic is a requirement for further error-analysis and that these are to be updated via Database Analyzer. -
Benjamin Franzke uploaded patch set 7
CR +1V +111/07/24, 10:51 -
Benjamin Franzke commented on patch set 7 11/07/24, 10:51
Important-104153-AboutDatabaseErrorRowSizeTooLarge.rst:104ReplyI decided to not drop the paragraphs for now, as the documentation will be available immediately and then users are "lost" until 13.4.1 is released. Also Garvin mentioned it's a bit of a pity if the information is just lost. So I let that be a "for later" task to reducde this and instead added on-top information that InnoDB and ROW_FORMAT are now migrated by the Database Analyzer. Please check and revote 😊 -
Andreas Kienast voted on patch set 7 CR +1 V +1 11/07/24, 10:53
-
core-ci voted on patch set 7 V +1 11/07/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69177
-
Stefan Bürk voted on patch set 7 CR +1 V +1 11/07/24, 11:35
-
Benjamin Franzke voted on patch set 7 CR +2 V +2 11/07/24, 11:36
-
Benjamin Franzke merged patch set 8 11/07/24, 11:46