Review main Merged Breaking

86879[!!!][TASK] Remove deprecated plugin and sub types functionality

Oli Bartsch CR +2 V +2 Expert +234 −1507 updated 11/05/24, 16:49

Commit message

This removes the previously deprecated special
"list" content type together with the corresponding
"list_type" sub type field.

Additionally, the general sub types feature
is removed altogether. The previously added
TCA migration is adjusted to unset the related
options `subtype_value_field`, `subtypes_addlist`
and `subtypes_excludelist`.

Due to the removal of mentioned functionality,
unused arguments are dropped from `EMU::addPlugin()`
and adjusted for `ExtensionUtility::configurePlugin()`.

Hence, the deprecated
`TYPO3\CMS\Extbase\Utility\ExtensionUtility::PLUGIN_TYPE_PLUGIN`
constant is removed as well.

Noteworthy: As consequence, the List.html
template as well as the corresponding
TypoScript configuration are removed from
EXT:fluid_styled_content.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Torben Hansen +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 4

Files 63

Show 43 more files

Review log 2435

Show 610 earlier messages
  1. Oli Bartsch uploaded patch set 1 11/04/24, 21:30

  2. Oli Bartsch updated the commit message in patch set 2 11/04/24, 21:31

  3. core-ci voted on patch set 1 V -1 11/04/24, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69056

  4. core-ci voted on patch set 2 V -1 11/04/24, 21:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69057

  5. Oli Bartsch uploaded patch set 3 V -1 11/04/24, 23:21

  6. Oli Bartsch updated the commit message in patch set 4 11/04/24, 23:21

  7. core-ci voted on patch set 4 V -1 11/04/24, 23:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69061

  8. Oli Bartsch uploaded patch set 5 V -1 11/04/24, 23:46

  9. core-ci voted on patch set 5 V +1 11/04/24, 23:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69062

  10. Oli Bartsch uploaded patch set 6 V +1 11/05/24, 08:03

  1. core-ci voted on patch set 6 V +1 11/05/24, 08:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69080

  2. Oli Bartsch uploaded patch set 7 V +1 11/05/24, 09:23

  3. Benni Mack commented on patch set 7 11/05/24, 09:25

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:206

    All others start with a \ this line doesn't.
  4. Oli Bartsch commented on patch set 8 11/05/24, 09:26

    Published edit on patch set 7.
  5. Oli Bartsch commented on patch set 8 11/05/24, 09:26

    Breaking-105377-DeprecatedFunctionalityRemoved.rst:206 Reply

    Done
  6. core-ci voted on patch set 7 V +1 11/05/24, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69089

  7. core-ci voted on patch set 8 V +1 11/05/24, 09:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69090

  8. Benni Mack voted on patch set 8 CR +1 V +1 11/05/24, 10:13

  9. Oli Bartsch uploaded patch set 9 CR +1 V +1 11/05/24, 10:38

  10. core-ci voted on patch set 9 V +1 11/05/24, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69093

  11. Garvin Hicking commented on patch set 10 V +1 11/05/24, 10:49

    Published edit on patch set 9.
  12. core-ci voted on patch set 10 V +1 11/05/24, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69095

  13. Benni Mack voted on patch set 10 CR +1 V +1 11/05/24, 11:55

  14. Oli Bartsch uploaded patch set 11 CR +1 V +1 11/05/24, 13:18

  15. Benni Mack voted on patch set 11 CR +1 V +1 11/05/24, 13:21

  16. core-ci voted on patch set 11 V +1 11/05/24, 13:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69097

  17. Nikita Hovratov uploaded patch set 12 CR +1 V +1 11/05/24, 14:07

  18. Nikita Hovratov voted on patch set 12 CR +1 11/05/24, 14:07

  19. core-ci voted on patch set 12 V +1 11/05/24, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69099

  20. Garvin Hicking commented on patch set 12 CR +1 11/05/24, 14:28

    (I read through it and couldn't find glaring issues, but the removed code is a bit beyond my 'active skillset')
  21. Benni Mack commented on patch set 12 11/05/24, 14:31

    Reply

    Apply the patch, if the base system still works, this is OK. This is a breaking change, we will find small issues (if there are any) later-on.
  22. Torben Hansen voted on patch set 12 CR +1 V +1 11/05/24, 15:23

  23. Benni Mack voted on patch set 12 CR +1 V +1 11/05/24, 16:41

  24. Oli Bartsch voted on patch set 12 CR +2 V +2 11/05/24, 16:49

  25. Oli Bartsch merged patch set 13 11/05/24, 16:49