86880[BUGFIX] Apply defaultTableOptions to CREATE TABLE DEFAULTS
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Thomas Hohn +1
- Anja Leichsenring +1
- Stefan Bürk +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
- Stefan Bürk +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1216
-
Benjamin Franzke uploaded patch set 1 11/05/24, 06:12
-
core-ci voted on patch set 1 V -1 11/05/24, 06:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69075
-
Benjamin Franzke uploaded patch set 2
V -111/05/24, 07:22 -
core-ci voted on patch set 2 V +1 11/05/24, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69077
-
Benjamin Franzke uploaded patch set 3
V +111/05/24, 09:36 -
core-ci voted on patch set 3 V +1 11/05/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69091
-
Benjamin Franzke rebased onto patch set 4
V +111/07/24, 19:40 -
core-ci voted on patch set 4 V +1 11/07/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69204
-
Anja Leichsenring voted on patch set 4 CR +1 V +1 11/08/24, 09:12
-
Thomas Hohn voted on patch set 4 CR +1 11/11/24, 05:36
-
Andreas Kienast voted on patch set 4 CR +1 V +1 11/11/24, 08:18
-
Benjamin Franzke commented on patch set 4 CR -1 11/11/24, 09:14
Temp -1 in case @stefan@buerk.tech wants to have a look. (thanks if you do! 😊)For reference: This case can only be reproduced in 13.4.0 or main before https://review.typo3.org/c/Packages/TYPO3.CMS/+/86860 (so checkout the parent 9419d58f). (Since the usage of the native platform now normalized columns to their table charset, this patch is still needed to ensure that table charsets are properly set) -
Stefan Bürk commented on patch set 4 11/11/24, 10:42
Reply
Start reviewing now ... -
Stefan Bürk commented on patch set 4 CR +1 V +1 11/11/24, 11:31
Reply
Thanks for taking care of this and the pre-patches. -
Benjamin Franzke voted on patch set 4 CR +2 V +2 11/11/24, 11:46
-
Benjamin Franzke merged patch set 5 11/11/24, 11:58