Review main Merged

86880[BUGFIX] Apply defaultTableOptions to CREATE TABLE DEFAULTS

Benjamin Franzke CR +2 V +2 Easy +47 −0 updated 11/11/24, 11:58

Commit message

The configured defaultTableOptions are now also applied to default
table options (not just to column definitions) to prevent mixed
scenarios, where columns have been updated to a newer charset
(like utf8mb4), but the table option defaults stayed at utf8.

Example (based on `show create table sys_note`) where the text column
charsets is utf8mb4 but table defaults were still set to utf8:

```
CREATE TABLE `sys_note` (
  `uid` int(10) unsigned NOT NULL AUTO_INCREMENT,
  `subject` varchar(255) CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '',
  `message` longtext CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci DEFAULT NULL,
  PRIMARY KEY (`uid`),
  KEY `parent` (`pid`,`deleted`)
) ENGINE=InnoDB AUTO_INCREMENT=3 DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci
```

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Thomas Hohn +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1216

  1. Benjamin Franzke uploaded patch set 1 11/05/24, 06:12

  2. core-ci voted on patch set 1 V -1 11/05/24, 06:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69075

  3. Benjamin Franzke uploaded patch set 2 V -1 11/05/24, 07:22

  4. core-ci voted on patch set 2 V +1 11/05/24, 07:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69077

  5. Benjamin Franzke uploaded patch set 3 V +1 11/05/24, 09:36

  6. core-ci voted on patch set 3 V +1 11/05/24, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69091

  7. Benjamin Franzke rebased onto patch set 4 V +1 11/07/24, 19:40

  8. core-ci voted on patch set 4 V +1 11/07/24, 19:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69204

  9. Anja Leichsenring voted on patch set 4 CR +1 V +1 11/08/24, 09:12

  10. Thomas Hohn voted on patch set 4 CR +1 11/11/24, 05:36

  11. Andreas Kienast voted on patch set 4 CR +1 V +1 11/11/24, 08:18

  12. Benjamin Franzke commented on patch set 4 CR -1 11/11/24, 09:14

    Temp -1 in case @stefan@buerk.tech wants to have a look. (thanks if you do! 😊)
    For reference: This case can only be reproduced in 13.4.0 or main before https://review.typo3.org/c/Packages/TYPO3.CMS/+/86860 (so checkout the parent 9419d58f). (Since the usage of the native platform now normalized columns to their table charset, this patch is still needed to ensure that table charsets are properly set)
  13. Stefan Bürk commented on patch set 4 11/11/24, 10:42

    Reply

    Start reviewing now ...
  14. Stefan Bürk commented on patch set 4 CR +1 V +1 11/11/24, 11:31

    Reply

    Thanks for taking care of this and the pre-patches.
  15. Benjamin Franzke voted on patch set 4 CR +2 V +2 11/11/24, 11:46

  16. Benjamin Franzke merged patch set 5 11/11/24, 11:58