Review main Merged

86883[BUGFIX] Add missing page content types section to user group compare

Oli Bartsch CR +2 V +2 Normal +39 −18 updated 11/06/24, 07:45

Commit message

This adds missing "Page Content Types"
section to the backend user group compare
view and also adjusts the display to match
the "Page Types" section, showing an icon
and using table layout instead of a list.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Oli Bartsch uploaded patch set 1 11/05/24, 14:18

  2. core-ci voted on patch set 1 V +1 11/05/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69100

  3. Andreas Kienast commented on patch set 1 V +1 11/05/24, 14:58

    UserInformationService.php:244

    You could write something like `[$table, $recordType, $recordTypeValue] = $split;`
  4. Oli Bartsch uploaded patch set 2 V +1 11/05/24, 15:37

  5. Oli Bartsch commented on patch set 2 11/05/24, 15:38

    UserInformationService.php:244 Reply

    Done
  6. Oli Bartsch uploaded patch set 3 11/05/24, 15:39

  7. core-ci voted on patch set 2 V +1 11/05/24, 15:45 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69108

  8. core-ci voted on patch set 3 V +1 11/05/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69109

  9. Andreas Kienast voted on patch set 3 CR +1 V +1 11/05/24, 15:48

  10. Garvin Hicking commented on patch set 3 11/05/24, 16:29

    In case of "N/A" content element maybe we can also find/utilize a distinct icon? Currently this looks a bit weirdly indented otherwise, screenshot: https://www.dropbox.com/s/5n3ldo84uwrue0z/Screenshot%202024-11-05%20at%2017.27.10.png?dl=0
  11. Oli Bartsch uploaded patch set 4 CR +1 V +1 11/05/24, 16:57

  12. Oli Bartsch uploaded patch set 5 11/05/24, 16:58

  13. Oli Bartsch commented on patch set 5 11/05/24, 16:59

  14. Oli Bartsch uploaded patch set 6 11/05/24, 17:00

  15. Garvin Hicking commented on patch set 6 CR +1 V +1 11/05/24, 17:03

    Nice! That's a cool improvement, thanks for addressing!
  16. core-ci voted on patch set 4 V +1 11/05/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69112

  17. core-ci voted on patch set 5 V +1 11/05/24, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69113

  18. core-ci voted on patch set 6 V +1 11/05/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69114

  19. Andreas Kienast voted on patch set 6 CR +1 V +1 11/06/24, 07:23

  20. Oli Bartsch voted on patch set 6 CR +2 V +2 11/06/24, 07:45

  21. Oli Bartsch merged patch set 7 11/06/24, 07:45