86883[BUGFIX] Add missing page content types section to user group compare
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1521
-
Oli Bartsch uploaded patch set 1 11/05/24, 14:18
-
core-ci voted on patch set 1 V +1 11/05/24, 14:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69100
-
Andreas Kienast commented on patch set 1 V +1 11/05/24, 14:58
-
Oli Bartsch uploaded patch set 2
V +111/05/24, 15:37 -
Oli Bartsch commented on patch set 2 11/05/24, 15:38
UserInformationService.php:244ReplyDone -
Oli Bartsch uploaded patch set 3 11/05/24, 15:39
-
core-ci voted on patch set 2 V +1 11/05/24, 15:45 Copied votes on follow-up patch sets have been updated: * Verified+1 has been copied to patch set 3 (copy condition: "changekind:NO_CHANGE"). Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69108
-
core-ci voted on patch set 3 V +1 11/05/24, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69109
-
Andreas Kienast voted on patch set 3 CR +1 V +1 11/05/24, 15:48
-
Garvin Hicking commented on patch set 3 11/05/24, 16:29
In case of "N/A" content element maybe we can also find/utilize a distinct icon? Currently this looks a bit weirdly indented otherwise, screenshot: https://www.dropbox.com/s/5n3ldo84uwrue0z/Screenshot%202024-11-05%20at%2017.27.10.png?dl=0 -
Oli Bartsch uploaded patch set 4
CR +1V +111/05/24, 16:57 -
Oli Bartsch uploaded patch set 5 11/05/24, 16:58
-
Oli Bartsch commented on patch set 5 11/05/24, 16:59
Reply
Alright, I think https://typo3.github.io/TYPO3.Icons/icons/install/install-check-extables.html works here. -
Oli Bartsch uploaded patch set 6 11/05/24, 17:00
-
Garvin Hicking commented on patch set 6 CR +1 V +1 11/05/24, 17:03
Nice! That's a cool improvement, thanks for addressing! -
core-ci voted on patch set 4 V +1 11/05/24, 17:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69112
-
core-ci voted on patch set 5 V +1 11/05/24, 17:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69113
-
core-ci voted on patch set 6 V +1 11/05/24, 17:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69114
-
Andreas Kienast voted on patch set 6 CR +1 V +1 11/06/24, 07:23
-
Oli Bartsch voted on patch set 6 CR +2 V +2 11/06/24, 07:45
-
Oli Bartsch merged patch set 7 11/06/24, 07:45
UserInformationService.php:244