86888[!!!][FEATURE] Support qualified and unqualified ISO8601 in DataHandler
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 31
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+12 −12
- Build/Sources/TypeScript/backend/date-time-picker.ts+10 −16
- Build/Sources/TypeScript/backend/form-engine-validation.ts+4 −4
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+9 −13
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php+5 −5
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+1 −8
- typo3/sysext/backend/Classes/Form/AbstractNode.php+3 −2
- typo3/sysext/backend/Resources/Public/JavaScript/date-time-picker.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php+13 −13
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+5 −5
- typo3/sysext/belog/Classes/Controller/BackendLogController.php+4 −0
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html2+4 −2
- typo3/sysext/core/Classes/Database/Query/QueryHelper.php+0 −4
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+64 −65
- typo3/sysext/core/Classes/Domain/DateTimeFormat.php3new+32 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-105549-ImprovedISO8601DateHandlingInTYPO3DataHandler.rst4new+103 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Feature-105549-SupportQualifiedAndUnqualifiedISO8601DatesInDataHandler.rstnew+82 −0
- typo3/sysext/core/Tests/Acceptance/Application/FormEngine/ElementsBasicInputDateCest.php+52 −52
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetBerlin.csv+2 −2
Show 11 more files
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultOffsetUTC.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/Legacy/ResultUTC0Berlin.csvrenamed+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultBerlinLocaltime.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultOffsetBerlin.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultOffsetUTC.csv+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/Datetime/ResultUTC0Berlin.csvrenamed+1 −1
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DatetimeTest.php+130 −24
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime/Configuration/TCA/tx_testdatahandler_datetime.php+0 −10
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_datahandler_datetime_legacy/Configuration/TCA/tx_testdatahandler_datetime_legacy.php+0 −10
- typo3/sysext/core/Tests/Unit/DataHandling/DataHandlerTest.php+262 −40
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+2 −5
Review log 5897
Show 4072 earlier messages
-
Benjamin Franzke uploaded patch set 1 11/06/24, 06:02
-
core-ci voted on patch set 1 V -1 11/06/24, 06:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69131
-
Benjamin Franzke uploaded patch set 2
V -111/06/24, 06:14 -
core-ci voted on patch set 2 V -1 11/06/24, 06:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69132
-
Benjamin Franzke uploaded patch set 3
V -111/06/24, 12:19 -
core-ci voted on patch set 3 V -1 11/06/24, 12:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69142
-
Benjamin Franzke uploaded patch set 4
V -111/06/24, 12:30 -
core-ci voted on patch set 4 V -1 11/06/24, 12:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69143
-
Benjamin Franzke uploaded patch set 5
V -111/06/24, 12:49 -
core-ci voted on patch set 5 V +1 11/06/24, 12:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69144
-
Benjamin Franzke updated the commit message in patch set 6
V +111/06/24, 13:32 -
core-ci voted on patch set 6 V +1 11/06/24, 13:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69145
-
Benjamin Franzke uploaded patch set 7
V +111/07/24, 02:22 -
core-ci voted on patch set 7 V -1 11/07/24, 02:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69158
-
Benjamin Franzke uploaded patch set 8
V -111/07/24, 08:39 -
core-ci voted on patch set 8 V +1 11/07/24, 08:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69172
-
Benjamin Franzke uploaded patch set 9
V +111/07/24, 09:27 -
core-ci voted on patch set 9 V -1 11/07/24, 09:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69173
-
Benjamin Franzke uploaded patch set 10
V -111/07/24, 09:39 -
core-ci voted on patch set 10 V +1 11/07/24, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69174
-
Benjamin Franzke uploaded patch set 11
V +111/07/24, 13:01 -
core-ci voted on patch set 11 V +1 11/07/24, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69186
-
Benjamin Franzke uploaded patch set 12
V +111/07/24, 13:50 -
core-ci voted on patch set 12 V -1 11/07/24, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69193
-
Benjamin Franzke uploaded patch set 13
V -111/07/24, 14:00 -
Benjamin Franzke uploaded patch set 14 11/07/24, 14:05
-
core-ci voted on patch set 14 V +1 11/07/24, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69196
-
Benjamin Franzke uploaded patch set 15
V +111/08/24, 05:47 -
core-ci voted on patch set 15 V +1 11/08/24, 05:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69217
-
Andreas Kienast commented on patch set 15 11/08/24, 07:22
Germanya UX ("ju-eks")otherwiseI'm confused, shouldn't this be `1999-11-11T12:11:11+01:00` here?Also here -
Benjamin Franzke updated the commit message in patch set 16
V +111/08/24, 07:30 -
Benjamin Franzke commented on patch set 16 11/08/24, 07:30
Reply
DoneReply
DoneReply
DoneReply
was only meant as an example, but I understand the confusion. yes, it is much better to point to the same date in time for all three examples.Reply
Done -
core-ci voted on patch set 16 V +1 11/08/24, 07:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69220
-
Benjamin Franzke rebased onto patch set 17
V +111/19/24, 22:45 -
core-ci voted on patch set 17 V +1 11/19/24, 22:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69752
-
Benjamin Franzke uploaded patch set 18
V +111/20/24, 06:33 -
core-ci voted on patch set 18 V +1 11/20/24, 06:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69768
-
Benjamin Franzke uploaded patch set 19
V +111/20/24, 21:12 -
core-ci voted on patch set 19 V +1 11/20/24, 21:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69874
-
Benjamin Franzke uploaded patch set 20
V +111/20/24, 21:43 -
core-ci voted on patch set 20 V -1 11/20/24, 21:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69876
-
Benjamin Franzke uploaded patch set 21
V -111/21/24, 07:48 -
core-ci voted on patch set 21 V +1 11/21/24, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69890
-
Garvin Hicking commented on patch set 21 12/04/24, 13:07
Can we relate #68651 to this as well, or is problematic timezone Extbase handling outside this scope? -
Benjamin Franzke commented on patch set 21 12/04/24, 13:29
Reply
Probably not related to this one as this is really about datahandler <=> formengine, but this could become part of a datetime epic (I don't want to promise too much though) and I think it is very important to finally fix that in extbase as well, yes. -
Andreas Kienast uploaded patch set 22
V +112/05/24, 15:07 -
core-ci voted on patch set 22 V +1 12/05/24, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70662
-
Benjamin Franzke uploaded patch set 23
V +112/08/24, 19:47 -
core-ci voted on patch set 23 V -1 12/08/24, 19:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70780
-
Benjamin Franzke uploaded patch set 24
V -112/08/24, 20:01 -
core-ci voted on patch set 24 V +1 12/08/24, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/70781
-
Benjamin Franzke marked it work in progress 12/19/24, 09:30
-
Benjamin Franzke uploaded patch set 25
V +103/17/25, 09:14 -
Benjamin Franzke uploaded patch set 26 03/17/25, 09:17
-
core-ci voted on patch set 25 V +1 03/17/25, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75701
-
core-ci voted on patch set 26 V +1 03/17/25, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75702
-
Benjamin Franzke uploaded patch set 27
V +103/17/25, 09:48 -
core-ci voted on patch set 27 V +1 03/17/25, 09:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75703
-
Benjamin Franzke uploaded patch set 28
V +103/17/25, 10:44 -
core-ci voted on patch set 28 V +1 03/17/25, 10:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75706
-
Benjamin Franzke uploaded patch set 29
V +103/18/25, 10:07 -
core-ci voted on patch set 29 V +1 03/18/25, 10:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75768
-
Benjamin Franzke uploaded patch set 30
V +103/18/25, 11:02 -
core-ci voted on patch set 30 V +1 03/18/25, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75771
-
Benjamin Franzke uploaded patch set 31
V +103/18/25, 11:13 -
core-ci voted on patch set 31 V +1 03/18/25, 11:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75773
-
Benjamin Franzke uploaded patch set 32
V +103/19/25, 13:35 -
core-ci voted on patch set 32 V +1 03/19/25, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75841
-
Benjamin Franzke uploaded patch set 33
V +103/20/25, 05:49 -
core-ci voted on patch set 33 V +1 03/20/25, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75869
-
Benni Mack commented on patch set 33 CR -1 03/20/25, 08:31
DateTimeFormat.php:20I do not understand why this is an interface - we have no consumer for this interface - we only use the constant - the name of the interface does not follow our naming conventions -
Benjamin Franzke commented on patch set 33 CR -1 03/20/25, 08:35
DateTimeFormat.php:20Replygood points. It basically mimics the nomenclature of https://www.php.net/manual/de/class.datetimeinterface.php#datetimeinterface.constants.iso8601 – but you are right, it missed the annoying Interface suffix and `Interface` does not really makes sense here. Will fix.
-
Benjamin Franzke uploaded patch set 34
CR -1V +103/20/25, 10:28 -
Benjamin Franzke commented on patch set 34 03/20/25, 10:28
DateTimeFormat.php:20ReplyDone -
core-ci voted on patch set 34 V +1 03/20/25, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75884
-
Benjamin Franzke uploaded patch set 35
V +103/21/25, 06:10 -
core-ci voted on patch set 35 V +1 03/21/25, 06:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75929
-
Benjamin Franzke uploaded patch set 36
V +103/21/25, 07:25 -
core-ci voted on patch set 36 V +1 03/21/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75938
-
Benjamin Franzke uploaded patch set 37
V +103/27/25, 10:20 -
core-ci voted on patch set 37 V +1 03/27/25, 10:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76434
-
Benni Mack updated the commit message in patch set 38
V +103/27/25, 12:19 -
core-ci voted on patch set 38 V +1 03/27/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76450
-
Benni Mack voted on patch set 38 CR +1 V +1 03/27/25, 12:32
-
Benjamin Franzke rebased onto patch set 39
CR +1V +103/27/25, 14:10 -
Benjamin Franzke marked it ready for review 03/27/25, 14:12
-
Benni Mack voted on patch set 39 CR +1 V +1 03/27/25, 14:13
-
core-ci voted on patch set 39 V +1 03/27/25, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76468
-
Andreas Kienast commented on patch set 39 03/27/25, 14:57
requiringFilter.html:119We could use `{f:constant(name: '\TYPO3\CMS\Core\Domain\DateTimeFormat::ISO8601_LOCALTIME')}` as well to make the connection more clear.DataHandler.php:2031PhpStorm complains here: > Expected parameter of type '\DateTime', '\DateTimeInterface' providedBreaking-105549-ImprovedISO8601DateHandlingInTYPO3DataHandler.rst:34essenceBreaking-105549-ImprovedISO8601DateHandlingInTYPO3DataHandler.rst:79shifting -
Andreas Kienast uploaded patch set 40
CR +1V +103/27/25, 15:01 -
Andreas Kienast commented on patch set 40 03/27/25, 15:01
Reply
DoneFilter.html:119ReplyDoneDataHandler.php:2031ReplyDoneBreaking-105549-ImprovedISO8601DateHandlingInTYPO3DataHandler.rst:34ReplyDoneBreaking-105549-ImprovedISO8601DateHandlingInTYPO3DataHandler.rst:79ReplyDone -
core-ci voted on patch set 40 V +1 03/27/25, 15:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76474
-
Benni Mack voted on patch set 40 CR +1 V +1 03/27/25, 15:12
-
Andreas Kienast voted on patch set 40 CR +1 V +1 03/27/25, 15:22
-
Benjamin Franzke voted on patch set 40 CR +2 V +2 03/27/25, 15:23
-
Benjamin Franzke merged patch set 41 03/27/25, 15:23
-
Lina Wolf commented on patch set 41 03/29/25, 09:57
We need some support in documenting this, I dont know enough about this topic to do it myself: https://github.com/TYPO3-Documentation/Changelog-To-Doc/issues/1227