Review 12.4 Merged

86893[BUGFIX] Fix LocalizationUtility in TS override mode not using defaults

Garvin Hicking CR +2 V +2 Normal +82 −2 updated 11/05/24, 07:47

Commit message

When using LocalizationUtility::translate in a context where
any TypoScript overrides via `_LOCAL_LANG` for the requested language
are set, a translation key lookup falls back to return "" (empty string),
even though the specifically requested translation key might not be
overridden at all.

In that case, a NULL value would be expected to detect missing
language keys (instead of empty values).

This patch will specifically check for a translation key to
exist in the `_LOCAL_LANG` TypoScript override.

Tests are added to verify this expected null value is now yielded.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Garvin Hicking commented on patch set 1 11/05/24, 07:40

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/05/24, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69079

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/05/24, 07:47

  4. Garvin Hicking merged patch set 2 11/05/24, 07:47