Review 13.4 Merged

86905[TASK] Add new list_type deprecation match to extension scanner

Garvin Hicking CR +2 V +2 Easy +12 −0 updated 11/07/24, 12:48

Commit message

With #105076, the plugin content element and plugin sub types
have been deprecated. The extension scanner currently only
matches the deprecation, when it detects the usage of
`ExtensionUtility::PLUGIN_TYPE_PLUGIN` as fifth argument
for `ExtensionUtility::configurePlugin()`. Many public
extensions however omit the fifth argument, resulting
in the deprecation not being shown in extension scanner
and extension developers not being aware of the required
code changes.

This change adds a new entry to the
`MethodArgumentRequiredStaticMatcher.php` configuration, so
the extension scanner will show a match for the deprecation,
if `ExtensionUtility::configurePlugin()` is called without
a fifth argument.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Garvin Hicking commented on patch set 1 11/07/24, 12:36

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/07/24, 12:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69182

  3. Garvin Hicking voted on patch set 1 CR +2 V +2 11/07/24, 12:48

  4. Garvin Hicking merged patch set 2 11/07/24, 12:48