86912[BUGFIX] Add FormEngine transformation for dbType=datetime in flexforms
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- Build/Sources/TypeScript/backend/tests/form-engine-validation-test.ts+88 −46
- Build/Sources/TypeScript/backend/form-engine-validation.ts+5 −17
- typo3/sysext/backend/Resources/Public/JavaScript/form-engine-validation.js+1 −1
- typo3/sysext/core/Configuration/DefaultConfiguration.php3+6 −1
- typo3/sysext/styleguide/Configuration/TCA/tx_styleguide_elements_basic.php+2 −2
Review log 1116
-
Benjamin Franzke uploaded patch set 1 11/06/24, 15:49
-
core-ci voted on patch set 1 V -1 11/06/24, 15:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69146
-
Benjamin Franzke uploaded patch set 2
V -111/06/24, 16:07 -
Benjamin Franzke uploaded patch set 3 11/06/24, 16:13
-
core-ci voted on patch set 2 V -1 11/06/24, 16:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69148
-
core-ci voted on patch set 3 V -1 11/06/24, 16:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69149
-
Benjamin Franzke uploaded patch set 4
V -111/06/24, 16:31 -
core-ci voted on patch set 4 V -1 11/06/24, 16:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69150
-
Benjamin Franzke uploaded patch set 5
V -111/06/24, 17:04 -
core-ci voted on patch set 5 V +1 11/06/24, 17:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69153
-
Andreas Kienast voted on patch set 5 CR +1 V +1 11/07/24, 12:24
-
Benni Mack voted on patch set 5 CR +1 V +1 11/15/24, 21:34
-
Benjamin Franzke commented on patch set 5 CR -1 11/18/24, 10:36
-
Christian Kuhn commented on patch set 5 11/19/24, 17:55
DefaultConfiguration.php:838ReplyThis feels good. I suppose not adding this DP to the flex group was an oversight. -
Benjamin Franzke commented on patch set 5 CR +2 V +2 11/19/24, 19:40
DefaultConfiguration.php:838ReplyThx, also manually verified different cases in the explicit elements_flex test as you suggested in private – no intent to merge that right now (to much chaos, and would rather require general testing of the _flex case), but pushed & abandoned immediately: > 87066: [WIP][TASK] Test input datetime in flex | https://review.typo3.org/c/Packages/TYPO3.CMS/+/87066 -
Benjamin Franzke merged patch set 6 11/19/24, 19:44
DefaultConfiguration.php:838