86915[BUGFIX] Display selected color for the color element
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 2
Files 6
- Build/Sources/Sass/component/forms/_input-group.scss+11 −0
- Build/Sources/TypeScript/backend/color-picker.ts+15 −1
- typo3/sysext/backend/Classes/Form/Element/ColorElement.php+16 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −0
- typo3/sysext/backend/Resources/Public/JavaScript/color-picker.js+1 −1
- typo3/sysext/install/Resources/Private/Partials/Settings/ExtensionConfiguration/ExtensionForm.html+11 −8
Review log 68
-
Oli Bartsch uploaded patch set 1 11/07/24, 11:45
-
core-ci voted on patch set 1 V +1 11/07/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69180
-
Andreas Kienast commented on patch set 1 11/07/24, 12:30
Somebody else pushed https://review.typo3.org/c/Packages/TYPO3.CMS/+/86914 as well. IMO, that approach looks more appealing but needs some more polishing. -
Benjamin Franzke commented on patch set 1 11/07/24, 12:31
FYI: The author of the bug also created a patch: > 86914: [BUGFIX] Add color preview for color field | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86914 We should probably squash these patches (ideally merge into his patch ;) ) -
Oli Bartsch uploaded patch set 2
V +111/07/24, 12:48 -
core-ci voted on patch set 2 V -1 11/07/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69185
-
Oli Bartsch abandoned the change 11/08/24, 08:12