Review main Abandoned

86915[BUGFIX] Display selected color for the color element

Oli Bartsch CR 0 V 0 Normal +55 −12 updated 11/08/24, 08:12

Commit message

With migrating the color picker to alwan in #101646,
the preview of the selected color got removed.

Since this information is quite important for
editors which do not necessarily understand
the hex values, especially for readonly fields,
the selected color is now displayed again.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 6

Review log 68

  1. Oli Bartsch uploaded patch set 1 11/07/24, 11:45

  2. core-ci voted on patch set 1 V +1 11/07/24, 11:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69180

  3. Andreas Kienast commented on patch set 1 11/07/24, 12:30

    Somebody else pushed https://review.typo3.org/c/Packages/TYPO3.CMS/+/86914 as well. IMO, that approach looks more appealing but needs some more polishing.
  4. Benjamin Franzke commented on patch set 1 11/07/24, 12:31

    FYI: The author of the bug also created a patch: > 86914: [BUGFIX] Add color preview for color field | https://review.typo3.org/c/Packages/TYPO3.CMS/+/86914 We should probably squash these patches (ideally merge into his patch ;) )
  5. Oli Bartsch uploaded patch set 2 V +1 11/07/24, 12:48

  6. Oli Bartsch commented on patch set 2 11/07/24, 12:52

    Reply Unresolved

    ACK

    Reply Unresolved

    ACK
  7. core-ci voted on patch set 2 V -1 11/07/24, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69185

  8. Oli Bartsch abandoned the change 11/08/24, 08:12