Review main Merged

86916[DOCS] Update changelog with JavaScript migration for goToModule

Garvin Hicking CR +2 V +2 Easy +23 −7 updated 03/29/25, 10:01

Commit message

When migrating JavaScript code that previously used
`(top.)goToModule()`, the current changelog entry for the
deprecation only mentioned how to adapt straight HTML code.

This patch now also gives an example to use the full TYPO3
JS API method `TYPO3.ModuleMenu.App.showModule()` inside
this scope.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Sybille Peters +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Sybille Peters +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1216

  1. Garvin Hicking uploaded patch set 1 11/07/24, 12:27

  2. core-ci voted on patch set 1 V +1 11/07/24, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69181

  3. Garvin Hicking commented on patch set 2 V +1 11/07/24, 12:38

    Published edit on patch set 1.
  4. Garvin Hicking commented on patch set 3 11/07/24, 12:39

    Published edit on patch set 2.
  5. core-ci voted on patch set 2 V +1 11/07/24, 12:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69183

  6. core-ci voted on patch set 3 V +1 11/07/24, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69184

  7. Sybille Peters voted on patch set 3 CR +1 V +1 11/07/24, 12:56

  8. Andreas Kienast commented on patch set 3 CR -1 11/07/24, 13:12

    Deprecation-94058-JavaScriptGoToModule.rst:53

    v11 didn't use ES modules
  9. Garvin Hicking commented on patch set 4 CR +1 V +1 11/07/24, 13:20

    Published edit on patch set 3.
  10. Garvin Hicking commented on patch set 4 11/07/24, 13:20

    Deprecation-94058-JavaScriptGoToModule.rst:53 Reply

    Done
  11. core-ci voted on patch set 4 V +1 11/07/24, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69188

  12. Sybille Peters voted on patch set 4 CR +1 V +1 11/07/24, 13:28

  13. Andreas Kienast voted on patch set 4 CR +1 V +1 11/07/24, 13:32

  14. Garvin Hicking voted on patch set 4 CR +2 V +2 11/07/24, 13:35

  15. Garvin Hicking merged patch set 5 11/07/24, 15:42

  16. Lina Wolf commented on patch set 5 03/29/25, 10:01