86920[TASK] Raise phpstan to 1.12.9
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
-
Verified V +2 Done
- Benjamin Franzke +2
- core-ci +1 CI
Issues 1
Files 3
Review log 1417
-
Anja Leichsenring uploaded patch set 1 11/08/24, 07:43
-
core-ci voted on patch set 1 V +1 11/08/24, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69221
-
Stefan Bürk voted on patch set 1 CR +1 V +1 11/08/24, 07:53
-
Markus Klein voted on patch set 1 CR +1 V +1 11/08/24, 08:00
-
Andreas Kienast commented on patch set 1 CR -1 11/08/24, 08:01
Why can't we fix the annotated issues? -
Anja Leichsenring commented on patch set 1 11/08/24, 08:10
Reply
it is a mis-detection. Two Interfaces are annoted, both feature a render method, one with parameter. So no, no fix available until DI can be used in those places to properly use BackendTemplateView. -
Anja Leichsenring commented on patch set 1 11/08/24, 08:11
Reply
which will never happen, because it is v12 only. -
Andreas Kienast commented on patch set 1 11/08/24, 08:18
Reply
It's fixable by declaring the affected properties to be a type of `TYPO3Fluid\Fluid\View\TemplateView`: * The view instance in ImageManipulationElement is hard-coded(!) to be `TemplateView` * The type union in FluidAdapter is actually broken as both interfaces conflict with each other. -
Andreas Kienast commented on patch set 1 11/08/24, 08:35
In v13 we basically have the same code but it's no issue there. Investigating... -
Sebastian Iffland voted on patch set 1 CR +1 V +1 11/08/24, 08:41
-
Benjamin Franzke commented on patch set 1 CR -2 11/08/24, 12:41
Let's keep this open for now and decide on monday. Reported an issue upstream: https://github.com/phpstan/phpstan/issues/11978 -
Benjamin Franzke uploaded patch set 2
CR +1V +111/11/24, 07:50Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benjamin Franzke commented on patch set 2 11/11/24, 07:51
Reply
DoneReply
As we isolated this as a phpstan bug, we'll not apply phpstan-related workarounds. -
core-ci voted on patch set 2 V -1 11/11/24, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69292
-
core-ci voted on patch set 2 V +1 11/11/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69292
-
Benjamin Franzke voted on patch set 2 CR +2 V +2 11/11/24, 09:05
-
Benjamin Franzke merged patch set 3 11/11/24, 09:05