Review 12.4 Merged

86920[TASK] Raise phpstan to 1.12.9

Anja Leichsenring CR +2 V +2 Easy +30 −10 updated 11/11/24, 09:05

Commit message

The PHPStan 1.12.8 and 1.12.9 releases contain bugs which
are added to our baseline for now.

The issues have been reported upstream:
1.12.8: https://github.com/phpstan/phpstan/issues/11978
1.12.9: https://github.com/phpstan/phpstan/issues/11992

Executed commands:

 * composer require --dev phpstan/phpstan:^1.12.9
 * Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 1417

  1. Anja Leichsenring uploaded patch set 1 11/08/24, 07:43

  2. core-ci voted on patch set 1 V +1 11/08/24, 07:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69221

  3. Stefan Bürk voted on patch set 1 CR +1 V +1 11/08/24, 07:53

  4. Markus Klein voted on patch set 1 CR +1 V +1 11/08/24, 08:00

  5. Andreas Kienast commented on patch set 1 CR -1 11/08/24, 08:01

    Why can't we fix the annotated issues?
  6. Anja Leichsenring commented on patch set 1 11/08/24, 08:10

    Reply

    it is a mis-detection. Two Interfaces are annoted, both feature a render method, one with parameter. So no, no fix available until DI can be used in those places to properly use BackendTemplateView.
  7. Anja Leichsenring commented on patch set 1 11/08/24, 08:11

    Reply

    which will never happen, because it is v12 only.
  8. Andreas Kienast commented on patch set 1 11/08/24, 08:18

    Reply

    It's fixable by declaring the affected properties to be a type of `TYPO3Fluid\Fluid\View\TemplateView`: * The view instance in ImageManipulationElement is hard-coded(!) to be `TemplateView` * The type union in FluidAdapter is actually broken as both interfaces conflict with each other.
  9. Andreas Kienast commented on patch set 1 11/08/24, 08:35

    In v13 we basically have the same code but it's no issue there. Investigating...
  10. Sebastian Iffland voted on patch set 1 CR +1 V +1 11/08/24, 08:41

  11. Benjamin Franzke commented on patch set 1 CR -2 11/08/24, 12:41

    Let's keep this open for now and decide on monday. Reported an issue upstream: https://github.com/phpstan/phpstan/issues/11978
  12. Benjamin Franzke uploaded patch set 2 CR +1 V +1 11/11/24, 07:50

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  13. Benjamin Franzke commented on patch set 2 11/11/24, 07:51

    Reply

    Done

    Reply

    As we isolated this as a phpstan bug, we'll not apply phpstan-related workarounds.
  14. core-ci voted on patch set 2 V -1 11/11/24, 07:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69292

  15. core-ci voted on patch set 2 V +1 11/11/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69292

  16. Benjamin Franzke voted on patch set 2 CR +2 V +2 11/11/24, 09:05

  17. Benjamin Franzke merged patch set 3 11/11/24, 09:05