86925[TASK] Transform all dates in DatabaseRowDateTimeFields to DateTime
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benjamin Kott +1
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- Benjamin Kott +1
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 13
- typo3/sysext/backend/Classes/Form/Container/FlexFormElementContainer.php3+2 −2
- typo3/sysext/backend/Classes/Form/Element/DatetimeElement.php+20 −44
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabaseRowDateTimeFields.php+5 −19
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaRecordTitle.php+4 −9
- typo3/sysext/backend/Classes/Utility/BackendUtility.php4+9 −2
- typo3/sysext/backend/Tests/Unit/Form/Element/DatetimeElementTest.php2+22 −19
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/DatabaseRowDateTimeFieldsTest.php+128 −34
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/TcaRecordTitleTest.php2+20 −27
- typo3/sysext/core/Classes/Domain/DateTimeFactory.php+2 −2
- typo3/sysext/core/Classes/Imaging/IconFactory.php+18 −7
- typo3/sysext/core/Configuration/DefaultConfiguration.php+13 −9
- typo3/sysext/redirects/Classes/Form/Element/RenderCreationInformation.php+1 −1
- typo3/sysext/scheduler/Classes/Form/Element/TimingOptionsElement.php+2 −3
Review log 5286
Show 3461 earlier messages
-
Benjamin Franzke uploaded patch set 1 11/10/24, 03:43
-
core-ci voted on patch set 1 V -1 11/10/24, 03:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69259
-
Benjamin Franzke uploaded patch set 2
V -111/10/24, 10:31 -
core-ci voted on patch set 2 V +1 11/10/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69267
-
Benjamin Franzke uploaded patch set 3
V +111/19/24, 22:45 -
core-ci voted on patch set 3 V -1 11/19/24, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69753
-
Benjamin Franzke uploaded patch set 4
V -111/20/24, 05:14 -
Benjamin Franzke marked it ready for review 11/20/24, 05:15
-
core-ci voted on patch set 4 V -1 11/20/24, 05:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69767
-
Benjamin Franzke uploaded patch set 5
V -111/20/24, 06:33 -
core-ci voted on patch set 5 V +1 11/20/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69769
-
Benjamin Franzke rebased onto patch set 6
V +111/20/24, 21:12 -
core-ci voted on patch set 6 V +1 11/20/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69875
-
Benjamin Franzke rebased onto patch set 7
V +111/20/24, 21:43 -
core-ci voted on patch set 7 V +1 11/20/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69877
-
Benjamin Franzke marked it work in progress 12/19/24, 09:30
-
Benjamin Franzke uploaded patch set 8
V +103/19/25, 17:50 -
core-ci voted on patch set 8 V -1 03/19/25, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75851
-
Benjamin Franzke uploaded patch set 9
V -103/19/25, 20:48 -
core-ci voted on patch set 9 V +1 03/19/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75852
-
Benjamin Franzke uploaded patch set 10
V +103/19/25, 21:13 -
core-ci voted on patch set 10 V -1 03/19/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75853
-
Benjamin Franzke uploaded patch set 11
V -103/20/25, 03:01 -
core-ci voted on patch set 11 V +1 03/20/25, 03:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75856
-
Benjamin Franzke rebased onto patch set 12
V +103/20/25, 05:49 -
core-ci voted on patch set 12 V +1 03/20/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75870
-
Benjamin Franzke uploaded patch set 13
V +103/20/25, 07:31 -
core-ci voted on patch set 13 V +1 03/20/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75876
-
Benjamin Franzke rebased onto patch set 14
V +103/20/25, 10:28 -
core-ci voted on patch set 14 V +1 03/20/25, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75885
-
Benjamin Franzke uploaded patch set 15
V +103/21/25, 06:11 -
core-ci voted on patch set 15 V +1 03/21/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75930
-
Benjamin Franzke rebased onto patch set 16
V +103/21/25, 07:25 -
core-ci voted on patch set 16 V +1 03/21/25, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75939
-
Benjamin Franzke rebased onto patch set 17
V +103/27/25, 10:24 -
core-ci voted on patch set 17 V +1 03/27/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76435
-
Benjamin Franzke uploaded patch set 18
V +103/29/25, 12:55 -
core-ci voted on patch set 18 V -1 03/29/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76637
-
Benjamin Franzke rebased onto patch set 19
V -103/29/25, 13:39 -
core-ci voted on patch set 19 V -1 03/29/25, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76641
-
Benjamin Franzke uploaded patch set 20
V -103/29/25, 14:13 -
core-ci voted on patch set 20 V +1 03/29/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76642
-
Benjamin Franzke uploaded patch set 21
V +103/31/25, 08:23 -
core-ci voted on patch set 21 V +1 03/31/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76714
-
Benjamin Franzke uploaded patch set 22
V +104/03/25, 19:21 -
Benjamin Franzke marked it work in progress 04/03/25, 19:22
-
core-ci voted on patch set 22 V +1 04/03/25, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76968
-
Benjamin Franzke rebased onto patch set 23
V +104/04/25, 12:19 -
core-ci voted on patch set 23 V +1 04/04/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77003
-
Benjamin Franzke uploaded patch set 24
V +105/30/25, 10:21 -
core-ci voted on patch set 24 V -1 05/30/25, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79689
-
Benjamin Franzke uploaded patch set 25
V -105/30/25, 10:37 -
core-ci voted on patch set 25 V -1 05/30/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79691
-
Benjamin Franzke uploaded patch set 26
V -105/30/25, 10:44 -
core-ci voted on patch set 26 V +1 05/30/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79692
-
Benni Mack commented on patch set 26 06/01/25, 20:10
-
Benjamin Franzke uploaded patch set 27
V +106/02/25, 07:28 -
Benjamin Franzke commented on patch set 27 06/02/25, 07:28
BackendUtility.php:1641Replyyes, could be. done! -
core-ci voted on patch set 27 V +1 06/02/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79740
-
Benni Mack voted on patch set 27 CR +1 V +1 06/02/25, 11:41
-
Stefan Bürk commented on patch set 27 06/06/25, 10:03
FlexFormElementContainer.php:106This will fail now if `$flexFormRowData[$flexFormFieldName]` is not set or not an array. (no longer guarded)
-
Benjamin Franzke uploaded patch set 28
CR +1V +106/06/25, 11:34 -
Benjamin Franzke commented on patch set 28 06/06/25, 11:34
FlexFormElementContainer.php:106Replyack, fixed! Out of interest: Do you know how that case could be triggered in reality? -
Stefan Bürk commented on patch set 28 06/06/25, 11:39
FlexFormElementContainer.php:106ReplyNot tried. Considerd only from reading and considered only that small context as not guranteed. Sorry for not making that clear beforehand. -
core-ci voted on patch set 28 V +1 06/06/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79988
-
Benni Mack voted on patch set 28 CR +1 V +1 06/06/25, 16:41
-
Benjamin Franzke uploaded patch set 29
CR +1V +110/17/25, 11:38 -
core-ci voted on patch set 29 V +1 10/17/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86891
-
Benni Mack voted on patch set 29 CR +1 10/30/25, 17:59
-
Markus Klein commented on patch set 29 10/31/25, 18:35
BackendUtility.php:1420$altLabelValue is not used. I guess it should be used in line 1422?DatetimeElementTest.php:103can we document with a comment please, what possible example values may be. I can't tell by reading whether setTimezone is actually correct here. See \TYPO3\CMS\Core\Domain\DateTimeFactory::createFromTimestamp -
Markus Klein commented on patch set 29 10/31/25, 18:39
TcaRecordTitleTest.php:257should we resolve this todo here? -
Benjamin Franzke uploaded patch set 30
CR +1V +101/28/26, 14:04 -
Benjamin Franzke commented on patch set 30 01/28/26, 14:04
BackendUtility.php:1420Replyack, fixed.DatetimeElementTest.php:103Replytrue, we should actually use `DateTimeFactory::createFomDatabaseValueAndTCAConfig`. Done (which revealed that some config options did not match the test values)TcaRecordTitleTest.php:257Replyack, done. -
core-ci voted on patch set 30 V -1 01/28/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94501
-
core-ci commented on patch set 30 01/28/26, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94501
-
Benjamin Franzke rebased onto patch set 31
V -101/30/26, 17:44 -
core-ci voted on patch set 31 V -1 01/30/26, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94694
-
Benni Mack uploaded patch set 32
V -101/30/26, 18:13 -
core-ci voted on patch set 32 V -1 01/30/26, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94696
-
Benni Mack uploaded patch set 33
V -101/30/26, 19:24 -
core-ci voted on patch set 33 V +1 01/30/26, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94699
-
Benni Mack voted on patch set 33 CR +1 V +1 02/02/26, 10:01
-
Benjamin Kott voted on patch set 33 CR +1 V +1 02/03/26, 10:15
-
Oli Bartsch voted on patch set 33 CR +1 V +1 02/03/26, 10:17
-
Georg Ringer voted on patch set 33 CR +2 V +2 02/03/26, 19:08
-
Georg Ringer merged patch set 34 02/03/26, 19:08
BackendUtility.php:1641