Review main Merged

86925[TASK] Transform all dates in DatabaseRowDateTimeFields to DateTime

Benjamin Franzke CR +2 V +2 Hard +246 −178 updated 02/03/26, 19:08

Commit message

Instead of parsing only native datetime fields into ISO8601
and leaving timestamp fields as-is (to be parsed by DatetimeElement),
DatabaseRowDateTimeFields is now adapted to take responsibility for
consistent parsing of all type=datetime TCA fields and resolves
to a `DateTimeImmutable` object, which is then used by data
consumers like DatetimeElement and TcaRecordTitle.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Benjamin Kott +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 13

Review log 5286

Show 3461 earlier messages
  1. Benjamin Franzke uploaded patch set 1 11/10/24, 03:43

  2. core-ci voted on patch set 1 V -1 11/10/24, 03:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69259

  3. Benjamin Franzke uploaded patch set 2 V -1 11/10/24, 10:31

  4. core-ci voted on patch set 2 V +1 11/10/24, 10:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69267

  5. Benjamin Franzke uploaded patch set 3 V +1 11/19/24, 22:45

  6. core-ci voted on patch set 3 V -1 11/19/24, 22:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69753

  7. Benjamin Franzke uploaded patch set 4 V -1 11/20/24, 05:14

  8. Benjamin Franzke marked it ready for review 11/20/24, 05:15

  9. core-ci voted on patch set 4 V -1 11/20/24, 05:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69767

  10. Benjamin Franzke uploaded patch set 5 V -1 11/20/24, 06:33

  11. core-ci voted on patch set 5 V +1 11/20/24, 06:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69769

  12. Benjamin Franzke rebased onto patch set 6 V +1 11/20/24, 21:12

  13. core-ci voted on patch set 6 V +1 11/20/24, 21:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69875

  14. Benjamin Franzke rebased onto patch set 7 V +1 11/20/24, 21:43

  15. core-ci voted on patch set 7 V +1 11/20/24, 21:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69877

  16. Benjamin Franzke marked it work in progress 12/19/24, 09:30

  17. Benjamin Franzke uploaded patch set 8 V +1 03/19/25, 17:50

  18. core-ci voted on patch set 8 V -1 03/19/25, 18:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75851

  19. Benjamin Franzke uploaded patch set 9 V -1 03/19/25, 20:48

  20. core-ci voted on patch set 9 V +1 03/19/25, 20:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75852

  21. Benjamin Franzke uploaded patch set 10 V +1 03/19/25, 21:13

  22. core-ci voted on patch set 10 V -1 03/19/25, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75853

  23. Benjamin Franzke uploaded patch set 11 V -1 03/20/25, 03:01

  24. core-ci voted on patch set 11 V +1 03/20/25, 03:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75856

  25. Benjamin Franzke rebased onto patch set 12 V +1 03/20/25, 05:49

  26. core-ci voted on patch set 12 V +1 03/20/25, 05:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75870

  27. Benjamin Franzke uploaded patch set 13 V +1 03/20/25, 07:31

  28. core-ci voted on patch set 13 V +1 03/20/25, 07:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75876

  29. Benjamin Franzke rebased onto patch set 14 V +1 03/20/25, 10:28

  30. core-ci voted on patch set 14 V +1 03/20/25, 10:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75885

  31. Benjamin Franzke uploaded patch set 15 V +1 03/21/25, 06:11

  32. core-ci voted on patch set 15 V +1 03/21/25, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75930

  33. Benjamin Franzke rebased onto patch set 16 V +1 03/21/25, 07:25

  34. core-ci voted on patch set 16 V +1 03/21/25, 07:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/75939

  35. Benjamin Franzke rebased onto patch set 17 V +1 03/27/25, 10:24

  36. core-ci voted on patch set 17 V +1 03/27/25, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76435

  37. Benjamin Franzke uploaded patch set 18 V +1 03/29/25, 12:55

  38. core-ci voted on patch set 18 V -1 03/29/25, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76637

  39. Benjamin Franzke rebased onto patch set 19 V -1 03/29/25, 13:39

  40. core-ci voted on patch set 19 V -1 03/29/25, 13:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76641

  41. Benjamin Franzke uploaded patch set 20 V -1 03/29/25, 14:13

  42. core-ci voted on patch set 20 V +1 03/29/25, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76642

  43. Benjamin Franzke uploaded patch set 21 V +1 03/31/25, 08:23

  44. core-ci voted on patch set 21 V +1 03/31/25, 08:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76714

  45. Benjamin Franzke uploaded patch set 22 V +1 04/03/25, 19:21

  46. Benjamin Franzke marked it work in progress 04/03/25, 19:22

  47. core-ci voted on patch set 22 V +1 04/03/25, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76968

  48. Benjamin Franzke rebased onto patch set 23 V +1 04/04/25, 12:19

  49. core-ci voted on patch set 23 V +1 04/04/25, 12:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77003

  50. Benjamin Franzke uploaded patch set 24 V +1 05/30/25, 10:21

  51. core-ci voted on patch set 24 V -1 05/30/25, 10:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79689

  52. Benjamin Franzke uploaded patch set 25 V -1 05/30/25, 10:37

  53. core-ci voted on patch set 25 V -1 05/30/25, 10:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79691

  54. Benjamin Franzke uploaded patch set 26 V -1 05/30/25, 10:44

  55. core-ci voted on patch set 26 V +1 05/30/25, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79692

  56. Benni Mack commented on patch set 26 06/01/25, 20:10

    BackendUtility.php:1641

    should this be DateTimeInterface?
  57. Benjamin Franzke uploaded patch set 27 V +1 06/02/25, 07:28

  58. Benjamin Franzke commented on patch set 27 06/02/25, 07:28

    BackendUtility.php:1641 Reply

    yes, could be. done!
  59. core-ci voted on patch set 27 V +1 06/02/25, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79740

  60. Benni Mack voted on patch set 27 CR +1 V +1 06/02/25, 11:41

  61. Stefan Bürk commented on patch set 27 06/06/25, 10:03

    FlexFormElementContainer.php:106

    This will fail now if `$flexFormRowData[$flexFormFieldName]` is not set or not an array. (no longer guarded)
  1. Benjamin Franzke uploaded patch set 28 CR +1 V +1 06/06/25, 11:34

  2. Benjamin Franzke commented on patch set 28 06/06/25, 11:34

    FlexFormElementContainer.php:106 Reply

    ack, fixed! Out of interest: Do you know how that case could be triggered in reality?
  3. Stefan Bürk commented on patch set 28 06/06/25, 11:39

    FlexFormElementContainer.php:106 Reply

    Not tried. Considerd only from reading and considered only that small context as not guranteed. Sorry for not making that clear beforehand.
  4. core-ci voted on patch set 28 V +1 06/06/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/79988

  5. Benni Mack voted on patch set 28 CR +1 V +1 06/06/25, 16:41

  6. Benjamin Franzke uploaded patch set 29 CR +1 V +1 10/17/25, 11:38

  7. core-ci voted on patch set 29 V +1 10/17/25, 11:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/86891

  8. Benni Mack voted on patch set 29 CR +1 10/30/25, 17:59

  9. Markus Klein commented on patch set 29 10/31/25, 18:35

    BackendUtility.php:1420

    $altLabelValue is not used. I guess it should be used in line 1422?

    DatetimeElementTest.php:103

    can we document with a comment please, what possible example values may be. I can't tell by reading whether setTimezone is actually correct here. See \TYPO3\CMS\Core\Domain\DateTimeFactory::createFromTimestamp
  10. Markus Klein commented on patch set 29 10/31/25, 18:39

    TcaRecordTitleTest.php:257

    should we resolve this todo here?
  11. Benjamin Franzke uploaded patch set 30 CR +1 V +1 01/28/26, 14:04

  12. Benjamin Franzke commented on patch set 30 01/28/26, 14:04

    BackendUtility.php:1420 Reply

    ack, fixed.

    DatetimeElementTest.php:103 Reply

    true, we should actually use `DateTimeFactory::createFomDatabaseValueAndTCAConfig`. Done (which revealed that some config options did not match the test values)

    TcaRecordTitleTest.php:257 Reply

    ack, done.
  13. core-ci voted on patch set 30 V -1 01/28/26, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94501

  14. core-ci commented on patch set 30 01/28/26, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94501

  15. Benjamin Franzke rebased onto patch set 31 V -1 01/30/26, 17:44

  16. core-ci voted on patch set 31 V -1 01/30/26, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94694

  17. Benni Mack uploaded patch set 32 V -1 01/30/26, 18:13

  18. core-ci voted on patch set 32 V -1 01/30/26, 18:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94696

  19. Benni Mack uploaded patch set 33 V -1 01/30/26, 19:24

  20. core-ci voted on patch set 33 V +1 01/30/26, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94699

  21. Benni Mack voted on patch set 33 CR +1 V +1 02/02/26, 10:01

  22. Benjamin Kott voted on patch set 33 CR +1 V +1 02/03/26, 10:15

  23. Oli Bartsch voted on patch set 33 CR +1 V +1 02/03/26, 10:17

  24. Georg Ringer voted on patch set 33 CR +2 V +2 02/03/26, 19:08

  25. Georg Ringer merged patch set 34 02/03/26, 19:08