Review main Merged

86926[DOCS] EMU::addPlugin was changed but not EMU::addTcaSelectItemGroup

TYPO3com CR +2 V +2 Easy +1 −1 updated 11/11/24, 08:44

Commit message

Follow up for https://review.typo3.org/c/Packages/TYPO3.CMS/+/86879

EMU::addPlugin was changed but not EMU::addTcaSelectItemGroup
https://review.typo3.org/c/Packages/TYPO3.CMS/+/86879/13/typo3/sysext/core
/Classes/Utility/ExtensionManagementUtility.php#b847

The parameters passed to EMU::addTcaSelectItemGroup have not been
changed even when compared to 12.4.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 611

  1. TYPO3com uploaded patch set 1 11/10/24, 13:27

  2. core-ci voted on patch set 1 V +1 11/10/24, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69268

  3. Lina Wolf updated the commit message in patch set 2 V +1 11/10/24, 13:34

  4. Simon Schaufelberger updated the commit message in patch set 3 11/10/24, 13:36

  5. core-ci voted on patch set 2 V +1 11/10/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69269

  6. core-ci voted on patch set 3 V +1 11/10/24, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69270

  7. Garvin Hicking updated the commit message in patch set 4 V +1 11/10/24, 14:11

  8. Garvin Hicking voted on patch set 4 CR +1 V +1 11/10/24, 14:16

  9. core-ci voted on patch set 4 V +1 11/10/24, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69271

  10. Oli Bartsch voted on patch set 4 CR +2 V +2 11/11/24, 08:44

  11. Oli Bartsch merged patch set 5 11/11/24, 08:44