Review main Merged

86927[DOCS] Correct removed class alias (Controller vs. AsController)

TYPO3com CR +2 V +2 Easy +1 −1 updated 11/11/24, 13:00

Commit message

In #105458 the class alias for `TYPO3\CMS\Backend\Attribute\Controller`
has been removed, while `TYPO3\CMS\Backend\Attribute\AsController` is
still in place.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 1117

  1. TYPO3com uploaded patch set 1 11/10/24, 15:27

  2. Lina Wolf commented on patch set 2 11/10/24, 15:28

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V +1 11/10/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69273

  4. core-ci voted on patch set 2 V +1 11/10/24, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69274

  5. Garvin Hicking commented on patch set 2 11/10/24, 16:51

    needs "related:" to the BC changelog and the asController change, issue also needs relations
  6. Oli Bartsch updated the commit message in patch set 3 V +1 11/11/24, 09:37

  7. Oli Bartsch commented on patch set 3 CR +1 V +1 11/11/24, 09:38

    Reply

    Done
  8. core-ci voted on patch set 3 V +1 11/11/24, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69297

  9. Garvin Hicking commented on patch set 3 CR +2 V +2 11/11/24, 10:09

    Thanks Oli for getting to it, I just had time to make the note for it yesterday
  10. Garvin Hicking updated the commit message in patch set 4 CR +1 V +1 11/11/24, 10:10

  11. Garvin Hicking commented on patch set 4 CR +2 V +2 11/11/24, 10:11

    (Will merge as low complexity issue with green CI verified, just minor typo in commit message)
  12. core-ci voted on patch set 4 V +1 11/11/24, 10:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69301

  13. Andreas Kienast updated the commit message in patch set 5 CR +2 V +1 11/11/24, 11:01

  14. Andreas Kienast commented on patch set 5 CR +1 V +1 11/11/24, 11:01

    Fixed the format of the commit message...
  15. core-ci voted on patch set 5 V +1 11/11/24, 11:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69302

  16. Garvin Hicking voted on patch set 5 CR +2 V +2 11/11/24, 12:59

  17. Garvin Hicking merged patch set 6 11/11/24, 13:00