Review main Merged

86930[TASK] Raise phpstan to 1.12.9

Benjamin Franzke CR +2 V +2 Easy +22 −7 updated 11/11/24, 09:05

Commit message

The PHPStan 1.12.9 release contain for-loop bugs which
are added to our baseline for now.

The issue has been reported upstream:
https://github.com/phpstan/phpstan/issues/11992

Executed commands:

 * composer require --dev phpstan/phpstan:^1.12.9
 * Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Benjamin Franzke uploaded patch set 1 11/11/24, 07:53

  2. core-ci voted on patch set 1 V +1 11/11/24, 08:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69293

  3. Andreas Kienast voted on patch set 1 CR +1 V +1 11/11/24, 08:20

  4. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/11/24, 08:58

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/11/24, 09:04

  6. Benjamin Franzke merged patch set 2 11/11/24, 09:05