Review main Merged

86953[TASK] Add `@since` to NullToDefaultUpdateWizard

Christian Kuhn CR +2 V +2 Easy +1 −0 updated 11/11/24, 16:27

Commit message

It's good to have these class annotations for
upgrade wizards to know when these may be removed
again.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 11/11/24, 13:35

  2. core-ci voted on patch set 1 V +1 11/11/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69307

  3. Benjamin Franzke commented on patch set 1 CR +1 V +1 11/11/24, 13:49

    Thanks makes total sense. I somehow copied from ´DatabaseRowsUpdateWizard` which is a long-term upgrade wizard (saying this because I wondered we might have forgotten it somewhere else as well, but that's only omitted for non-release specific upgrade wizard)
  4. Stefan Bürk voted on patch set 1 CR +1 V +1 11/11/24, 16:13

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/11/24, 16:15

  6. Benjamin Franzke merged patch set 2 11/11/24, 16:27