Review main Merged

86954[TASK] Raise phpstan to 1.12.10

Benjamin Franzke CR +2 V +2 Easy +7 −22 updated 11/11/24, 19:48

Commit message

PHPStan 1.12.10 fixes the for-loop bugs [1] which
we added to our baseline in #105559.
These are now being removed again.

Executed commands:

 * composer require --dev phpstan/phpstan:^1.12.10
 * Build/Scripts/runTests.sh -s phpstanGenerateBaseline

[1] https://github.com/phpstan/phpstan/issues/11992

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 45

  1. Benjamin Franzke uploaded patch set 1 11/11/24, 17:15

  2. core-ci voted on patch set 1 V +1 11/11/24, 17:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69310

  3. Anja Leichsenring voted on patch set 1 CR +1 V +1 11/11/24, 17:33

  4. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/11/24, 19:48

  5. Benjamin Franzke merged patch set 2 11/11/24, 19:48