86957[BUGFIX] Respect model type configuration in ColumnMapFactory
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1014
-
Oli Bartsch uploaded patch set 1 11/11/24, 19:26
-
core-ci voted on patch set 1 V +1 11/11/24, 19:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69318
-
Oli Bartsch uploaded patch set 2
V +111/11/24, 19:52 -
core-ci voted on patch set 2 V +1 11/11/24, 19:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69321
-
Oli Bartsch uploaded patch set 3
V +111/11/24, 20:32 -
Oli Bartsch uploaded patch set 4 11/11/24, 20:38
-
core-ci voted on patch set 3 V +1 11/11/24, 20:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69322
-
core-ci voted on patch set 4 V +1 11/11/24, 20:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69323
-
Benni Mack voted on patch set 4 CR +1 V +1 11/11/24, 21:35
-
Benjamin Franzke commented on patch set 4 CR +1 11/12/24, 04:59
stray space -
Benjamin Franzke commented on patch set 4 CR +2 V +2 11/12/24, 05:34
Hm, I don't think we have a testcase for the case that was reported to be broken: thawObjectProperty throws an error if a relation is defined in extbase, but not assigned (`0` in database). We basically test the prerequisites for that to work. …but that's fine by me for now, as I could at least manually verify that the issue is resolved: mapping 0 to NULL works when extbase-defined relations (type=passthrough) are used.Reply
don't care for now… -
Benjamin Franzke commented on patch set 4 CR 0 V -1 11/12/24, 05:57
Reply
Hm, I could not verify that in the 13.4 backport: https://review.typo3.org/c/Packages/TYPO3.CMS/+/86936/1#message-083267bd90553a2db221a4c6e8db5491620331f4 something seems to be missing for 13.4… -
Benjamin Franzke commented on patch set 4 CR +2 V +2 11/12/24, 07:09
Reply
-
Benjamin Franzke merged patch set 5 11/12/24, 07:09