Review main Abandoned

86959[BUGFIX] Remove "Bootstrap::initializeBackendAuthentication" in "extension:setup"

Jochen Roth CR 0 V -1 Easy +22 −2 updated 07/15/26, 10:28

Commit message

Currenlty, the "extension:setup" command initializes the backend user
authentication. But the backend authentication requires the "be_users"
tables which does not exist yet on an empty database.

This has been fixed, by removing the backend user authentication.
So the table creation will run successfully.

Review

  • Code review CR 0
  • Verified V -1
    • Anja Leichsenring -1
    • core-ci +1 CI

Issues 1

Files 2

Review log 811

  1. Jochen Roth uploaded patch set 1 11/11/24, 23:01

  2. Jochen Roth uploaded patch set 2 11/11/24, 23:01

  3. core-ci voted on patch set 1 V -1 11/11/24, 23:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69324

  4. core-ci voted on patch set 2 V -1 11/11/24, 23:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69325

  5. Jochen Roth uploaded patch set 3 V -1 11/12/24, 09:51

  6. core-ci voted on patch set 3 V +1 11/12/24, 10:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69359

  7. Oli Bartsch commented on patch set 3 11/12/24, 10:44

    SetupExtensionsCommand.php:77 Unresolved

    While this makes the test pass. I'm kind of unsure whether this can simply be removed. I assume there was a reason to call this here? Could you investigate this a bit - or did you already had a look?
  8. Anja Leichsenring commented on patch set 3 V -1 12/06/24, 13:09

    I don't like that addition / change in behaviour and detailed my reasoning in the forge ticket. Please reevaluate your approach here and let's discuss.
  9. Benni Mack marked it work in progress 03/27/25, 11:43

  10. Lina Wolf commented on patch set 3 10/09/25, 06:05

    Reply Unresolved

    I agree that using the extension:setup command on an empty database does not really make sense. However the issue with setup command is that it forces you to overwrite / redo all of the configuration options. If your settings.php etc are already all set you do not want to do that just to reinitialize an empty database. How would you feel about introducing a flag for the setup command to run it without overriding the settings instead?
  11. Jochen Roth abandoned the change 07/15/26, 10:28