86967[BUGFIX] Localize header for editing site settings
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +2
- Georg Ringer +1
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1114
-
Garvin Hicking uploaded patch set 1 11/12/24, 09:26
-
core-ci voted on patch set 1 V +1 11/12/24, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69355
-
Georg Ringer commented on patch set 1 CR -1 11/13/24, 06:47
I guess this will break if a translation is not adopted and the %s is missing. I would suggest to use a new key -
Garvin Hicking commented on patch set 2
CR -1V +111/13/24, 06:57Published edit on patch set 1. -
core-ci voted on patch set 2 V -1 11/13/24, 07:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69391
-
Garvin Hicking commented on patch set 2 11/13/24, 07:27
Reply
Thank you, that's a sensitive approach. Adjusted to use a fresh key. (Note that the former one had a wrong 'resname' so I'm unsure if it could have been translated properly even?) -
Georg Ringer commented on patch set 2 11/13/24, 07:40
Reply
resname is just for display support, therefore not really a problem if wrong -
Benjamin Franzke uploaded patch set 3
V -111/15/24, 14:39 -
core-ci voted on patch set 3 V +1 11/15/24, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69486
-
Georg Ringer voted on patch set 3 CR +1 V +1 11/15/24, 16:01
-
Garvin Hicking voted on patch set 3 CR +2 V +2 11/15/24, 16:08
-
Benni Mack voted on patch set 3 CR +1 11/15/24, 16:23
-
Benjamin Franzke voted on patch set 3 CR +2 V +2 11/15/24, 17:01
-
Benjamin Franzke merged patch set 4 11/15/24, 17:01