Review main Merged

86974[BUGFIX] Consider all sheets for flexform field lookup

Nikita Hovratov CR +2 V +2 Normal +114 −17 updated 11/13/24, 18:29

Commit message

The corresponding FlexFormSchema->getFields() method is
adjusted to actually look in all sheets for a requested
field name, in case no sheet is excplicitly given.

This fixes record field transformation for flexform
definitions with multiple sheets, having custom
sheet identifier.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Nikita Hovratov +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 814

  1. Nikita Hovratov uploaded patch set 1 11/12/24, 14:03

  2. core-ci voted on patch set 1 V -1 11/12/24, 14:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69367

  3. Nikita Hovratov uploaded patch set 2 V -1 11/12/24, 14:17

  4. core-ci voted on patch set 2 V -1 11/12/24, 14:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69368

  5. Oli Bartsch uploaded patch set 3 V -1 11/12/24, 21:19

  6. core-ci voted on patch set 3 V -1 11/12/24, 21:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69373

  7. Oli Bartsch uploaded patch set 4 V -1 11/13/24, 09:05

  8. core-ci voted on patch set 4 V -1 11/13/24, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69395

  9. core-ci commented on patch set 4 11/13/24, 14:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69395

  10. core-ci voted on patch set 4 V +1 11/13/24, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69395

  11. Benni Mack voted on patch set 4 CR +1 V +1 11/13/24, 16:45

  12. Nikita Hovratov voted on patch set 4 CR +1 V +1 11/13/24, 17:36

  13. Oli Bartsch voted on patch set 4 CR +2 V +2 11/13/24, 18:29

  14. Oli Bartsch merged patch set 5 11/13/24, 18:29