Review main Merged

86975[DOCS] Add hint to use PHP spread operator for DBAL conditions

TYPO3com CR +2 V +2 Easy +17 −0 updated 12/17/24, 18:07

Commit message

Quite often constraints should only be added under certain
conditions to a logical AND or OR comparison. Composing
a list/array of constraints is a quite common use case. The
usage of the PHP spread operator is well suited for this scenario.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. TYPO3com uploaded patch set 1 11/12/24, 14:36

  2. core-ci voted on patch set 1 V -1 11/12/24, 14:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69369

  3. Mathias Brodala commented on patch set 1 11/12/24, 15:07

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:77

    Without explanation array_values() does not add anything useful here and should be removed.
  4. Stefan Bürk commented on patch set 1 CR -1 11/12/24, 16:03

    Working on it ...
  5. Stefan Bürk uploaded patch set 2 CR -1 V -1 12/17/24, 17:28

  6. Stefan Bürk commented on patch set 2 12/17/24, 17:28

    Reply

    Done
  7. Stefan Bürk commented on patch set 2 12/17/24, 17:28

    Breaking-96044-HardenMethodSignatureOfLogicalAndAndLogicalOr.rst:77 Reply

    Done
  8. Garvin Hicking updated the commit message in patch set 3 12/17/24, 17:34

  9. Garvin Hicking commented on patch set 3 CR +1 V +1 12/17/24, 17:35

    Works for me. It might be interesting to spell out where named arguments could be helpful, but that's a sidequest IMO.
  10. core-ci voted on patch set 2 V +1 12/17/24, 17:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71303

  11. core-ci voted on patch set 3 V +1 12/17/24, 17:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71304

  12. Stefan Bürk voted on patch set 3 CR +2 V +2 12/17/24, 17:54

  13. Stefan Bürk merged patch set 4 12/17/24, 18:07