Review 12.4 Abandoned

86978[TASK] Temporarily workaround a missing conflict in symfony/type-info for composer tests

Benjamin Franzke CR 0 V 0 Easy +3 −0 updated 11/13/24, 18:37

Commit message

`symfony/type-info` is currently not compatible to
`phpstan/phpdoc-parser` 2.x which results in a PHP error in extbase
modules as shown in #105582.
A fix has been merged upstream, but has not been released yet and
it seems there will be no immediate hotfix release by symfony – that
means it will only be released by the end of the month [2]).

Explanation of the issue:

`phpdocumentor/reflection-docblock` 5.6.0 [1] was released yesterday
which allows `composer install` and `composer update` to raise
`phpstan/phpdoc-parser` to 2.x.

Since symfony/type-info has an optional dependency to
`phpstan/phpdoc-parser`, a conflict is used to express the
supported version. This upstream conflict has a weak range [3]
as it only forbids incompatible old versions, but not new upcoming
*major*(!) versions.
The statement `"conflict": "<1.0"`[3] forbids to install any
version before 1.0, but missed to opt out from future major releases
(which are allowed to be breaking per semver).

Now that `phpstan/phpdoc-parser` 2.x has been released and is allowed
to be installed by other dependencies like
`phpdocumentor/reflection-docblock` (which is perfectly fine), this
range flaw got revealed.

This workaround will be removed once `symfony/type-info` has been
updated to allow an upgrade to `phpstan/phpdoc-parser`. For that
reason this conflict is only added to the testing instance and not
to extbase (extbase is incompatible, `symfony/type-info` is).

[1] https://github.com/phpDocumentor/ReflectionDocBlock/releases/tag/5.6.0
[2] https://github.com/symfony/symfony/pull/58800#issuecomment-2471013822
[3] https://github.com/symfony/type-info/blob/v7.1.6/composer.json#L36-L37
[4] https://github.com/symfony/symfony/pull/58800#issuecomment-2470646929

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 1

Review log 23

  1. Benjamin Franzke uploaded patch set 1 11/13/24, 05:21

  2. core-ci voted on patch set 1 V +1 11/13/24, 05:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69388

  3. Benjamin Franzke abandoned the change 11/13/24, 18:37