Review main Merged

86979[DOCS] Hint LanguageService->sL() docs on placeholder usage

Garvin Hicking CR +2 V +2 Easy +35 −0 updated 11/14/24, 09:38

Commit message

The inline code comment is used for rendering the documentation
at [1]. It currently is missing information that LanguageService->sL()
is not doing any placeholder interpolation, and that this needs
to be performed individually.

People may lean towards using Extbase LocalizationUtility in
a wrong context, because that offers placeholder substitution.

[1] https://docs.typo3.org/permalink/t3coreapi:LanguageService-api

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Lina Wolf +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Anja Leichsenring +1
    • Lina Wolf +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1116

  1. Garvin Hicking uploaded patch set 1 11/13/24, 07:56

  2. Anja Leichsenring commented on patch set 1 CR -1 11/13/24, 08:05

    LanguageService.php:134

    a concrete example would help a lot. I will improve that in the afternoon.
  3. core-ci voted on patch set 1 V -1 11/13/24, 08:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69392

  4. Anja Leichsenring uploaded patch set 2 CR -1 V -1 11/13/24, 13:42

  5. core-ci voted on patch set 2 V +1 11/13/24, 13:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69401

  6. Anja Leichsenring uploaded patch set 3 V +1 11/13/24, 14:00

  7. core-ci voted on patch set 3 V +1 11/13/24, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69402

  8. Anja Leichsenring commented on patch set 2 11/13/24, 14:07

    LanguageService.php:134 Reply

    Done
  9. Garvin Hicking commented on patch set 4 V +1 11/13/24, 14:20

    Published edit on patch set 3.
  10. core-ci voted on patch set 4 V +1 11/13/24, 14:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69403

  11. Garvin Hicking commented on patch set 5 V +1 11/14/24, 09:10

    Published edit on patch set 4.
  12. Anja Leichsenring voted on patch set 5 CR +1 V +1 11/14/24, 09:10

  13. core-ci voted on patch set 5 V +1 11/14/24, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69426

  14. Lina Wolf voted on patch set 5 CR +1 V +1 11/14/24, 09:18

  15. Garvin Hicking voted on patch set 5 CR +2 V +2 11/14/24, 09:22

  16. Garvin Hicking merged patch set 6 11/14/24, 09:38