86980[TASK] Provide expression with TypoScript condition errors
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Georg Ringer +1
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Mathias Brodala uploaded patch set 1 11/13/24, 08:51
-
Mathias Brodala uploaded patch set 2 11/13/24, 08:59
-
core-ci voted on patch set 1 V -1 11/13/24, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69393
-
core-ci voted on patch set 2 V -1 11/13/24, 09:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69394
-
core-ci voted on patch set 1 V -1 11/13/24, 09:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69393
-
Stefan Bürk commented on patch set 2 11/13/24, 14:46
-
Mathias Brodala commented on patch set 2 11/13/24, 14:53
IncludeTreeConditionMatcherVisitor.php:177ReplyWhile I fully agree I'd say it's beyond the scope of this change. If you have a look at the remaining code in the "TYPO3\CMS\Core\TypoScript" namespace you'll see that only generic exceptions are thrown. All of these should be replaced by specific exceptions IMO. -
Garvin Hicking commented on patch set 2 V +1 11/13/24, 18:44
This is very helpful! Questions about the cause of this show up at least once a week in support channels and would really help a lot.IncludeTreeConditionMatcherVisitor.php:177ReplyMaybe for new code we could already introduce a new exception (extending runtimeException, so that current consumers still can catch the broader exception), and then we can either have a pre/post patch revisiting the other instances? -
Garvin Hicking updated the commit message in patch set 3
V +111/13/24, 18:44 -
core-ci voted on patch set 3 V +1 11/13/24, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69409
-
Benni Mack commented on patch set 3 CR +1 11/14/24, 07:09
IncludeTreeConditionMatcherVisitor.php:177Replymaybe we open a new ticket and change these occurrences in v14? -
Georg Ringer voted on patch set 3 CR +1 V +1 03/02/25, 15:09
-
Garvin Hicking commented on patch set 3 CR +1 V +1 03/02/25, 17:08
IncludeTreeConditionMatcherVisitor.php:177ReplyGood for me. Let's get this wrapped as a start. -
Christian Kuhn commented on patch set 3 03/03/25, 12:18
IncludeTreeConditionMatcherVisitor.php:177Replyi think many thrown generic \RuntimeExceptions in TypoScript/ are ok, they often sanitize internal programming stuff. i agree turning this \RuntimeException into something else is out of scope of this patch and changing this will only help us in practice if we actually do something with it on a higher level. my current gut feeling is we still want to let it bubble up into casual exception handler: a broken condition syntax is an (integrator) programming error after all (as opposed to an editor error), and this should stop processing. however, it looks to me as if the catch-and-rethrow of \RuntimeException could and should be relocated to TYPO3\CMS\Core\ExpressionLanguage\Resolver? -
Mathias Brodala commented on patch set 3 03/03/25, 12:28
IncludeTreeConditionMatcherVisitor.php:177Reply> however, it looks to me as if the catch-and-rethrow of \RuntimeException could and should be relocated to TYPO3\CMS\Core\ExpressionLanguage\Resolver? That would however require a more generic exception message which can only refer to "expression". This would make it harder again to understand that the error lies in a faulty TypoScript condition. -
Christian Kuhn commented on patch set 3 CR +1 V +1 03/03/25, 12:30
IncludeTreeConditionMatcherVisitor.php:177ReplyAcknowledged. Fine with me then. -
Christian Kuhn voted on patch set 3 CR +2 V +2 03/03/25, 12:58
-
Christian Kuhn merged patch set 4 03/03/25, 12:58
IncludeTreeConditionMatcherVisitor.php:177