86982[BUGFIX] Use same hash mechanism for comparing staticSqlFile
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Thomas Hohn +1
- Garvin Hicking +1
- Himanshu Nitsan +1
- Sebastian Fischer +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Garvin Hicking +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1417
-
Oli Bartsch uploaded patch set 1 11/13/24, 13:03
-
core-ci voted on patch set 1 V +1 11/13/24, 13:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69398
-
Oli Bartsch updated the commit message in patch set 2
V +111/13/24, 14:24 -
Sebastian Fischer voted on patch set 2 CR +1 11/13/24, 14:28
-
core-ci voted on patch set 2 V +1 11/13/24, 14:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69404
-
Garvin Hicking commented on patch set 2 11/13/24, 14:31
-
Himanshu Nitsan voted on patch set 2 CR +1 11/13/24, 14:35
-
Oli Bartsch uploaded patch set 3
CR +1V +111/13/24, 14:38 -
Oli Bartsch commented on patch set 3 11/13/24, 14:40
ReloadSqlDataViewHelper.php:68ReplyRenamed the variables. No the hash in the database won't change with this patch since we did not change the hash method in the event listener. We just use the correct mechanism here for validation now. Even if, it would not do any harm to re-import the data. -
core-ci voted on patch set 3 V +1 11/13/24, 14:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69405
-
Thomas Hohn voted on patch set 3 CR +1 11/13/24, 15:22
-
Garvin Hicking voted on patch set 3 CR +1 V +1 11/14/24, 07:38
-
Sebastian Fischer voted on patch set 3 CR +1 11/14/24, 16:23
-
Himanshu Nitsan voted on patch set 3 CR +1 11/15/24, 05:02
-
Benni Mack voted on patch set 3 CR +1 V +1 11/15/24, 13:36
-
Oli Bartsch voted on patch set 3 CR +2 V +2 11/15/24, 20:46
-
Oli Bartsch merged patch set 4 11/15/24, 20:46
ReloadSqlDataViewHelper.php:68