Review main Abandoned

86989[BUGFIX] Prevent undefined array key in CObjectViewHelper

André Buchmann CR 0 V 0 Easy +2 −2 updated 11/14/24, 16:52

Commit message

Use null coalescing operator to access optional arguments.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. André Buchmann uploaded patch set 1 11/14/24, 14:14

  2. core-ci voted on patch set 1 V +1 11/14/24, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69437

  3. Simon Praetorius commented on patch set 1 CR -1 11/14/24, 14:44

    This patch isn't necessary if you use the proper API to instantiate ViewHelpers, which Fluid also uses internally: The ViewHelperInvoker.
  4. André Buchmann abandoned the change 11/14/24, 16:52

    No need when ViewHelperInvoker is used. See issue for details