86993[BUGFIX] Adapt migration for changed folder_identifier SQL definition
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 3
Files 1
Review log 911
-
Nikita Hovratov uploaded patch set 1 11/14/24, 17:45
-
core-ci voted on patch set 1 V +1 11/14/24, 17:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69442
-
Benjamin Franzke commented on patch set 1 11/14/24, 20:06
Can you explain how an old v11 record (that is to be migrated because v12 must have been skipped) can have the new v13 default value. The new-NULL-default should only have been applied to new records, which should not need a v12 migration. Can you share here or in the ticket an actual error and/or insights how this state could be established? -
Nikita Hovratov commented on patch set 1 11/14/24, 20:20
Reply
Exactly, I skipped v12. Pretty standard to skip one major version on updates. Field `folder_identifier` got added in v12 + migration, which I skipped. So it only was created with v13 having the new default `NULL`, which the migration wizard doesn't handle. -
Nikita Hovratov updated the commit message in patch set 2
V +111/14/24, 20:25 -
core-ci voted on patch set 2 V +1 11/14/24, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69444
-
Garvin Hicking commented on patch set 2 CR +1 V +1 11/15/24, 08:45
I personally don't skip major updates, but I setup a dummy installation like this and the upgrader then works. (sidenote, possible folder_identifier='' records stay at '' and are not converted to NULL through the DB compare, which is okay/expected I'd say, and they still work properly) -
Benjamin Franzke commented on patch set 2 CR +1 11/15/24, 08:46
Reply
Yea, perfectly fine to skip one major version. Good explanation and thanks for updating the commit message accordingly. -
Benjamin Franzke voted on patch set 2 V +1 11/15/24, 12:32
-
Benjamin Franzke commented on patch set 2 CR +2 V +2 11/15/24, 12:34
Reply
Yes, that's ok, as it was added as a new field in v12. Existing records with string contents !== '' are therefore already migrated (or new) -
Benjamin Franzke merged patch set 3 11/15/24, 12:34