Review main Merged

86994[BUGFIX] Add default extbase TypoScript into ext_localconf.php

Nikita Hovratov CR +2 V +2 Easy +19 −9 updated 11/15/24, 07:23

Commit message

As Site Sets do not load global TypoScript from ext_typoscript_setup
files, extbase default settings are moved to ext_localconf registration.

For v14 it should be considered to bake these defaults into the code.
They have been around for quite a while now and are de-facto the new
standard since they were introduced.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Nikita Hovratov uploaded patch set 1 11/14/24, 18:03

  2. core-ci voted on patch set 1 V +1 11/14/24, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69443

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 11/14/24, 20:00

  4. Oli Bartsch voted on patch set 1 CR +1 V +1 11/14/24, 21:13

  5. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/15/24, 06:55

  6. Benjamin Franzke merged patch set 2 11/15/24, 07:23