Review main Merged

86995[DOCS] Add note about global TypoScript to #103439 Feature.rst

Benjamin Franzke CR +2 V +2 Easy +43 −2 updated 11/15/24, 22:29

Commit message

Explain why `ext_typoscript_setup.typoscript` and
`ext_typoscript_constants.typoscript` are not loaded in site sets
and what to do instead.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1013

  1. Benjamin Franzke uploaded patch set 1 11/15/24, 07:52

  2. Benjamin Franzke commented on patch set 1 11/15/24, 07:54

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:103

    I guess this is wrong. rendering says: > [2024-11-15T07:52:11.462652+00:00] app.WARNING: Inventory link with key "typo3/cms-form:Concepts/Configuration/Index#concepts-configuration-yamlregistration-backend-addtyposcriptsetup" (Concepts/Configuration/Index) not found. {"rst-file":"Changelog/13.1/Feature-103439-TypoScriptProviderForSitesAndSets","type":"doc","targetReference":"Concepts/Configuration/Index#concepts-configuration-yamlregistration-backend-addtyposcriptsetup","value":"YAML registration for the Rendering I'm asking Garvin for help..
  3. core-ci voted on patch set 1 V +1 11/15/24, 07:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69458

  4. Benjamin Franzke uploaded patch set 2 V +1 11/15/24, 08:01

  5. Benjamin Franzke commented on patch set 2 11/15/24, 08:05

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:103 Reply

    Done, thanks Garvin.
  6. Nikita Hovratov commented on patch set 2 11/15/24, 08:06

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:81

    do not need
  7. core-ci voted on patch set 2 V +1 11/15/24, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69459

  8. Garvin Hicking commented on patch set 3 V +1 11/15/24, 08:12

    Published edit on patch set 2.
  9. Garvin Hicking commented on patch set 3 CR +1 V +1 11/15/24, 08:12

    Feature-103439-TypoScriptProviderForSitesAndSets.rst:81 Reply

    Done
  10. core-ci voted on patch set 3 V +1 11/15/24, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69460

  11. Nikita Hovratov voted on patch set 3 CR +1 V +1 11/15/24, 21:29

  12. Garvin Hicking voted on patch set 3 CR +2 V +2 11/15/24, 22:17

  13. Garvin Hicking merged patch set 4 11/15/24, 22:29