Review main Merged

86997[BUGFIX] Improve keyboard accessibility of page module actions

Benjamin Kott CR +2 V +2 Easy +13 −6 updated 11/20/24, 14:12

Commit message

Ensure faded elements become visible when the user focuses
elements inside, and align action stylings content block actions.
Add missing text for screenreaders to the column edit button.

This affects:
- Column edit button
- Hidden content blocks

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Andreas Nedbal +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 914

  1. Benjamin Kott uploaded patch set 1 11/15/24, 11:53

  2. Benjamin Kott updated the commit message in patch set 2 11/15/24, 11:54

  3. Benjamin Kott uploaded patch set 3 11/15/24, 11:59

  4. core-ci voted on patch set 1 V +1 11/15/24, 12:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69473

  5. core-ci voted on patch set 2 V +1 11/15/24, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69474

  6. core-ci voted on patch set 3 V +1 11/15/24, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69475

  7. Benjamin Kott uploaded patch set 4 11/15/24, 13:15

    Copied Votes: * Verified+1 (copy condition: "**changekind:NO_CHANGE**")
  8. core-ci voted on patch set 4 V +1 11/15/24, 13:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69481

  9. Benjamin Kott rebased onto patch set 5 V +1 11/18/24, 16:47

  10. core-ci voted on patch set 5 V +1 11/18/24, 16:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69608

  11. Andreas Nedbal voted on patch set 5 CR +1 V +1 11/18/24, 17:24

  12. Andreas Kienast voted on patch set 5 CR +1 V +1 11/20/24, 12:32

  13. Andreas Kienast voted on patch set 5 CR +2 V +2 11/20/24, 14:12

  14. Andreas Kienast merged patch set 6 11/20/24, 14:12