Review 12.4 Merged

86999[TASK] Disable unapplied TS-highlighting for unknown-variables in CodeMirror

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 11/15/24, 20:19

Commit message

This removes any TS-highlighting for unknown-variables in CodeMirror.
This does not visually change the styling of unknown-variables.

Before a style `other` was defined to be applied to unknown-variables,
but the style `other` does not exist.
Thereby no style was applied and the unknown-variables were already
styled in default-text-style 'black'.

Before a warning was shown in browser's dev console:
`Unknown highlighting tag other`

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch uploaded patch set 1 11/15/24, 19:58

  2. core-ci voted on patch set 1 V +1 11/15/24, 20:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69496

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/15/24, 20:19

  4. Oli Bartsch merged patch set 2 11/15/24, 20:19