Review 13.4 Merged

87000[TASK] Disable unapplied TS-highlighting for unknown-variables in CodeMirror

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 11/15/24, 21:05

Commit message

This removes any TS-highlighting for unknown-variables in CodeMirror.
This does not visually change the styling of unknown-variables.

Before a style `other` was defined to be applied to unknown-variables,
but the style `other` does not exist.
Thereby no style was applied and the unknown-variables were already
styled in default-text-style 'black'.

Before a warning was shown in browser's dev console:
`Unknown highlighting tag other`

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Oli Bartsch uploaded patch set 1 11/15/24, 20:19

  2. core-ci voted on patch set 1 V -1 11/15/24, 20:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69497

  3. Oli Bartsch uploaded patch set 2 V -1 11/15/24, 20:59

  4. core-ci voted on patch set 2 V +1 11/15/24, 21:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69501

  5. Oli Bartsch voted on patch set 2 CR +2 V +2 11/15/24, 21:05

  6. Oli Bartsch merged patch set 3 11/15/24, 21:05