Review main Abandoned

87003[BUGFIX] Fix FlexForm schema creation for ds key "default"

Nikita Hovratov CR 0 V 0 Normal +142 −3 updated 11/18/24, 19:19

Commit message

It's possible to add a fallback data structure by defining
the key "default". This special key is now excluded from the
struct identifier, so that the comparison with the schema
name in getSchemaForRecord will succeed.

In addition, a condition for getRecordType is changed to
compare against null. Otherwise, record types with value
"0" won't be considered.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 3

Review log 35

  1. Nikita Hovratov uploaded patch set 1 11/16/24, 13:27

  2. core-ci voted on patch set 1 V +1 11/16/24, 13:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69527

  3. Nikita Hovratov uploaded patch set 2 V +1 11/17/24, 13:35

  4. core-ci voted on patch set 2 V +1 11/17/24, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69552

  5. Oli Bartsch abandoned the change 11/18/24, 19:19

    Will be solved differently.