Review main Merged

87005[BUGFIX] Children of selectTree filter should be expandable

Sybille Peters CR +2 V +2 Easy +24 −8 updated 11/20/24, 19:39

Commit message

This patch changes the behaviour of TCA renderType selectTree
filter so that it is possible to see unfiltered children of
nodes for which the filter matches. Previously, all nodes
were hidden if the filter did not match them.

Now, the behaviour initially looks the same, but it is possible
to expand the lowest filtered node and see the unfiltered
children (as in the page tree).

Review

  • Code review CR +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Nedbal +2
    • Garvin Hicking +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2640

Show 915 earlier messages
  1. Sybille Peters uploaded patch set 1 11/17/24, 08:47

  2. core-ci voted on patch set 1 V +1 11/17/24, 08:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69544

  3. Sybille Peters commented on patch set 1 CR -1 11/17/24, 09:32

    still working on it
  4. Sybille Peters uploaded patch set 2 CR -1 V +1 11/17/24, 10:41

  5. core-ci voted on patch set 2 V +1 11/17/24, 10:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69545

  6. Sybille Peters updated the commit message in patch set 3 V +1 11/17/24, 10:51

  7. core-ci voted on patch set 3 V +1 11/17/24, 10:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69546

  8. Sybille Peters uploaded patch set 4 V +1 11/17/24, 11:13

  9. core-ci voted on patch set 4 V -1 11/17/24, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69547

  10. Sybille Peters uploaded patch set 5 V -1 11/17/24, 11:31

  11. core-ci voted on patch set 5 V +1 11/17/24, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69548

  12. Garvin Hicking commented on patch set 5 V +1 11/18/24, 13:48

    👍
  13. Simon Schaufelberger commented on patch set 5 CR -1 11/19/24, 18:29

    merge conflict
  14. Garvin Hicking uploaded patch set 6 CR -1 V +1 11/19/24, 19:53

  15. core-ci voted on patch set 6 V +1 11/19/24, 20:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69745

  1. Garvin Hicking commented on patch set 6 V +1 11/19/24, 20:09

    Reply

    Done
  2. Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/19/24, 20:42

  3. Andreas Nedbal uploaded patch set 7 CR +1 V +1 11/20/24, 12:31

  4. core-ci voted on patch set 7 V +1 11/20/24, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69791

  5. Andreas Nedbal uploaded patch set 8 V +1 11/20/24, 13:51

  6. core-ci voted on patch set 8 V +1 11/20/24, 13:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69797

  7. Andreas Nedbal uploaded patch set 9 V +1 11/20/24, 14:11

  8. core-ci voted on patch set 9 V +1 11/20/24, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69800

  9. Andreas Nedbal rebased onto patch set 10 V +1 11/20/24, 16:14

    The following files contain Git conflicts: * typo3/sysext/backend/Resources/Public/JavaScript/form-engine/element/select-tree.js
  10. Andreas Nedbal uploaded patch set 11 11/20/24, 16:16

  11. Andreas Nedbal marked it ready for review 11/20/24, 16:16

  12. core-ci voted on patch set 11 V +1 11/20/24, 16:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69815

  13. core-ci voted on patch set 10 V -1 11/20/24, 16:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69814

  14. Garvin Hicking commented on patch set 11 CR +1 V +1 11/20/24, 16:59

    Works for me. I cannot attest for the JS code, but I can read+understand it, so it's good for me. ;-)
  15. Andreas Nedbal uploaded patch set 12 CR +1 V +1 11/20/24, 17:12

  16. Andreas Nedbal uploaded patch set 13 11/20/24, 17:14

  17. core-ci voted on patch set 12 V -1 11/20/24, 17:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69825

  18. core-ci voted on patch set 13 V +1 11/20/24, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69828

  19. Andreas Nedbal uploaded patch set 14 V +1 11/20/24, 18:36

  20. core-ci voted on patch set 14 V +1 11/20/24, 18:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69842

  21. Garvin Hicking commented on patch set 14 CR +1 V +1 11/20/24, 18:57

    Woohoo :)
  22. Benjamin Kott voted on patch set 14 CR +1 V +1 11/20/24, 19:07

  23. Andreas Nedbal voted on patch set 14 CR +2 11/20/24, 19:16

  24. Andreas Nedbal voted on patch set 14 V +2 11/20/24, 19:16

  25. Andreas Nedbal merged patch set 15 11/20/24, 19:39