Review main Merged

87007[TASK] Improve behaviour of FormEngine selectTree with maxitems=1

Sybille Peters CR +2 V +2 Easy +25 −2 updated 11/19/24, 17:52

Commit message

If maxitems=1, the previously selected item should get
unselected if a new item is selected.

EXT:styleguide showcases this with the newly introduced
select_tree_7 element.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Nedbal +1
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1115

  1. Sybille Peters uploaded patch set 1 11/17/24, 12:49

  2. core-ci voted on patch set 1 V -1 11/17/24, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69550

  3. Sybille Peters uploaded patch set 2 V -1 11/17/24, 13:14

  4. core-ci voted on patch set 2 V +1 11/17/24, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69551

  5. Andreas Nedbal uploaded patch set 3 V +1 11/18/24, 21:54

  6. Andreas Nedbal voted on patch set 2 CR +1 V +1 11/18/24, 21:54

  7. core-ci voted on patch set 3 V +1 11/18/24, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69631

  8. Garvin Hicking uploaded patch set 4 V +1 11/19/24, 11:19

  9. Garvin Hicking commented on patch set 4 CR +1 V +1 11/19/24, 11:20

    I relabelled this to "TASK" because I believe this is not a bugfix, but an improvement in usability. I've added an EXT:styleguide example to showcase this. Hope the changes are ok for you.
  10. core-ci voted on patch set 4 V +1 11/19/24, 11:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69691

  11. Andreas Nedbal voted on patch set 4 CR +1 V +1 11/19/24, 14:31

  12. Oli Bartsch commented on patch set 4 CR -1 11/19/24, 14:59

    Reviewing
  13. Oli Bartsch voted on patch set 4 CR +2 V +2 11/19/24, 15:05

  14. Oli Bartsch merged patch set 5 11/19/24, 15:05

  15. Christian Kuhn commented on patch set 5 11/19/24, 17:52

    Reply

    Done