Review main Merged

87009[BUGFIX] Fix showing of parent items in select tree filtering

Andreas Nedbal CR +2 V +2 Easy +2 −2 updated 11/20/24, 16:12

Commit message

Multiple issues existed when filtering lists of a depth of at least 2:

* In the list of parents, the first element was used,
  which is usually the identifier '0', to recursively
  show the parents, we need to use the last element.

* Using the identifier directly to access an element
  inside this.nodes was wrong too because that would
  use the identifier as an array index, breaking on
  IDs that are higher than the node element count.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oli Bartsch +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1216

  1. Andreas Nedbal uploaded patch set 1 11/18/24, 09:29

  2. core-ci voted on patch set 1 V -1 11/18/24, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69574

  3. Andreas Nedbal uploaded patch set 2 V -1 11/18/24, 09:42

  4. core-ci voted on patch set 2 V +1 11/18/24, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69577

  5. Garvin Hicking voted on patch set 2 CR +1 V +1 11/18/24, 10:48

  6. Andreas Nedbal updated the commit message in patch set 3 CR +1 V +1 11/18/24, 19:37

  7. core-ci voted on patch set 3 V +1 11/18/24, 19:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69618

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 11/18/24, 19:47

  9. Simon Schaufelberger commented on patch set 3 CR -1 11/19/24, 18:28

    merge conflict
  10. Garvin Hicking uploaded patch set 4 CR +1 V +1 11/19/24, 19:58

  11. core-ci voted on patch set 4 V +1 11/19/24, 20:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69746

  12. Garvin Hicking commented on patch set 4 CR +1 V +1 11/19/24, 20:10

    Reply

    Done
  13. Simon Schaufelberger voted on patch set 4 CR +1 V +1 11/19/24, 20:41

  14. Oli Bartsch voted on patch set 4 CR +1 V +1 11/20/24, 12:29

  15. Garvin Hicking voted on patch set 4 CR +2 V +2 11/20/24, 15:38

  16. Garvin Hicking merged patch set 5 11/20/24, 16:12