Review 13.4 Merged

87012[BUGFIX] Fix rendering of native datetime fields as record title

Benjamin Franzke CR +2 V +2 Easy +13 −1 updated 11/18/24, 08:59

Commit message

FormDataProvider\DatabaseRowDateTimeFields misinterprets the native
LOCALTIME datetime value as UTC and creates an invalid ISO8601
datetime string in the current server timezone based on the incorrectly
assumed UTC base value, which means the time value has an effective
timezone offset that matches the current server timezone.

As a backportable workaround the timezone offset is now normalized back
to LOCALTIME, as a change to DatabaseRowDateTimeFields would be
considered breaking.
This ugly workaround will be removed with a refactoring of
DatabaseRowDateTimeFields to use unqualified ISO8601 localtime
in #105549.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Benjamin Franzke commented on patch set 1 11/18/24, 08:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/18/24, 08:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69567

  3. Benjamin Franzke voted on patch set 1 CR +2 V +2 11/18/24, 08:54

  4. Benjamin Franzke merged patch set 2 11/18/24, 08:59