Review main Merged

87032[BUGFIX] Prevent PHP error with empty link tag

Simon Praetorius CR +2 V +2 Easy +1 −1 updated 11/19/24, 21:03

Commit message

If `<f:link.action />` is called with invalid parameters (e. g. a
non-existent page uid), the uri generation fails and returns an empty
string instead. In that case, only the provided tag content is used,
without any `<a>` tag. This fails with a PHP type error if no content
is provided and `$this->renderChildren()` returns `null`. That value
is now cast to a string to prevent the type error.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Simon Praetorius +2
    • Garvin Hicking +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Simon Praetorius uploaded patch set 1 11/18/24, 10:54

  2. core-ci voted on patch set 1 V +1 11/18/24, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69586

  3. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/18/24, 11:49

  4. Garvin Hicking voted on patch set 1 CR +1 V +1 11/18/24, 17:46

  5. Garvin Hicking updated the commit message in patch set 2 CR +1 V +1 11/19/24, 17:48

  6. Garvin Hicking voted on patch set 2 CR +1 V +1 11/19/24, 17:48

  7. core-ci voted on patch set 2 V +1 11/19/24, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69733

  8. Christian Kuhn voted on patch set 2 CR +1 V +1 11/19/24, 19:54

  9. Simon Praetorius voted on patch set 2 CR +2 V +2 11/19/24, 21:02

  10. Simon Praetorius merged patch set 3 11/19/24, 21:03