Review 12.4 Merged

87034[BUGFIX] Resolve references of extension forms

Christian Kuhn CR +2 V +2 Hard +352 −13 updated 11/18/24, 14:27

Commit message

The EXT:form management GUI shows all forms and where
they are used (referenced).

Forms can be either stored in FAL-based storages
(mainly used by editors) or be shipped in extensions
(EXT:my_extension/Resources/Private/Forms/my.form.yaml).

Clicking on the number of references opens a popup
that reveals all references to a given form, but this
could not deal with EXT:... notations and throwing
an exception, instead of returning the sys_refindex
records that actually contain the exact reference.

This patch now resolves the sys_refindex differently,
depending on whether these notations are used:

* FAL-based storage with UID
* FAL-based storage with string
* public EXT:... notation
* private EXT:... notation

Tests are added to ensure this behavior.

Inspecting references will no longer trigger an
exception, but an empty result set to continue
the sys_refindex inspection.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 11

Review log 45

  1. Christian Kuhn uploaded patch set 1 11/18/24, 13:36

  2. core-ci voted on patch set 1 V +1 11/18/24, 13:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69596

  3. Garvin Hicking voted on patch set 1 CR +1 V +1 11/18/24, 13:49

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 11/18/24, 14:27

  5. Garvin Hicking merged patch set 2 11/18/24, 14:27