Review main Merged

87035[BUGFIX] Fix styling of disabled nullable fields

Andreas Nedbal CR +2 V +2 Easy +13 −13 updated 11/20/24, 10:11

Commit message

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • Benjamin Kott +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Nikita Hovratov +1
    • Benjamin Kott +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1113

  1. Andreas Nedbal uploaded patch set 1 11/18/24, 14:51

  2. core-ci voted on patch set 1 V +1 11/18/24, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69604

  3. Nikita Hovratov commented on patch set 1 CR +1 V +1 11/18/24, 15:11

    Not perfect, but much better than before. The whole area is still "grayed out", not just the field.
  4. Andreas Kienast commented on patch set 1 V -1 11/18/24, 15:35

    As discussed at the sprint: I'm in favor in fixing this correctly instead of having several patches for the same issue.
  5. Nikita Hovratov voted on patch set 1 CR 0 V 0 11/18/24, 16:41

  6. Nikita Hovratov commented on patch set 1 11/18/24, 16:41

    Reply

    ack
  7. Benjamin Kott uploaded patch set 2 V +1 11/18/24, 17:09

  8. Benjamin Kott commented on patch set 2 CR +1 V +1 11/18/24, 17:14

    Reply

    this seems to be the best way for now, we still have the description field and the nullable selector visible and the CSS is now more scoped around that. in general, i agree it would be better to disable the fields, but it can be seen as template as we are running this code in multiple elements in the released LTS. without changing the markup this one should do it for now until further refactoring of the form engine markup
  9. core-ci voted on patch set 2 V +1 11/18/24, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69611

  10. Nikita Hovratov voted on patch set 2 CR +1 V +1 11/18/24, 17:21

  11. Andreas Kienast voted on patch set 2 CR +2 V +2 11/20/24, 10:04

  12. Andreas Kienast commented on patch set 2 11/20/24, 10:04

    Reply

    Done
  13. Andreas Kienast merged patch set 3 11/20/24, 10:11