Review main Merged

87036[BUGFIX] Apply fallback chain for Extbase entities with language sets

Benni Mack CR +2 V +2 Normal +47 −5 updated 03/24/25, 20:03

Commit message

This change adds the fallback chain for entities retrieved
directly (findByUid) or related entities via DataMapper.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Benni Mack uploaded patch set 1 11/18/24, 15:38

  2. core-ci voted on patch set 1 V +1 11/18/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69606

  3. Simon Schaufelberger commented on patch set 1 11/20/24, 01:38

    Data
  4. Josef Glatz updated the commit message in patch set 2 V +1 11/20/24, 04:27

  5. Josef Glatz commented on patch set 2 11/20/24, 04:28

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 11/20/24, 04:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69762

  7. Achim Fritz voted on patch set 2 CR +1 V +1 11/20/24, 07:25

  8. Garvin Hicking commented on patch set 2 11/20/24, 11:53

    I've tried to add tests for this in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87095 The problem is, it currently cannot verify that it is wrong in first place, probably the language configuration does not exactly match the original issue. Would be nice to back this patch with a test. I do believe this patch here fixes a fallback issue, so not blocking anything here.
  9. Albrecht Köhnlein commented on patch set 2 03/19/25, 10:39

    Forget it. I think, it's godd.

    DataMapper.php:455

    I am wondering if these two lines are related to his problem and if they should be changed to correct language id and language content id? ``` $languageAspect->getId(), $languageAspect->getContentId(), ```
  10. Benni Mack uploaded patch set 3 CR +1 V +1 03/22/25, 19:13

  11. core-ci voted on patch set 3 V +1 03/22/25, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76041

  12. Garvin Hicking voted on patch set 3 CR +1 V +1 03/24/25, 18:42

  13. Georg Ringer voted on patch set 3 CR +2 V +2 03/24/25, 20:03

  14. Georg Ringer merged patch set 4 03/24/25, 20:03