87036[BUGFIX] Apply fallback chain for Extbase entities with language sets
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Garvin Hicking +1
-
Verified V +2 Done
- Georg Ringer +2
- Garvin Hicking +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/extbase/Classes/Persistence/Generic/Mapper/DataMapper.php1+2 −1
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+2 −1
- typo3/sysext/extbase/Tests/Functional/Persistence/Fixtures/parentChildTranslationExampleData.csv+7 −3
- typo3/sysext/extbase/Tests/Functional/Persistence/ParentChildTranslationTest.php+36 −0
Review log 1114
-
Benni Mack uploaded patch set 1 11/18/24, 15:38
-
core-ci voted on patch set 1 V +1 11/18/24, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69606
-
Simon Schaufelberger commented on patch set 1 11/20/24, 01:38
Data -
Josef Glatz updated the commit message in patch set 2
V +111/20/24, 04:27 -
Josef Glatz commented on patch set 2 11/20/24, 04:28
Reply
Done -
core-ci voted on patch set 2 V +1 11/20/24, 04:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69762
-
Achim Fritz voted on patch set 2 CR +1 V +1 11/20/24, 07:25
-
Garvin Hicking commented on patch set 2 11/20/24, 11:53
I've tried to add tests for this in https://review.typo3.org/c/Packages/TYPO3.CMS/+/87095 The problem is, it currently cannot verify that it is wrong in first place, probably the language configuration does not exactly match the original issue. Would be nice to back this patch with a test. I do believe this patch here fixes a fallback issue, so not blocking anything here. -
Albrecht Köhnlein commented on patch set 2 03/19/25, 10:39
Forget it. I think, it's godd.DataMapper.php:455I am wondering if these two lines are related to his problem and if they should be changed to correct language id and language content id? ``` $languageAspect->getId(), $languageAspect->getContentId(), ``` -
Benni Mack uploaded patch set 3
CR +1V +103/22/25, 19:13 -
core-ci voted on patch set 3 V +1 03/22/25, 19:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76041
-
Garvin Hicking voted on patch set 3 CR +1 V +1 03/24/25, 18:42
-
Georg Ringer voted on patch set 3 CR +2 V +2 03/24/25, 20:03
-
Georg Ringer merged patch set 4 03/24/25, 20:03