Review 13.4 Merged

87039[BUGFIX] Prevent PHP errors for empty Fluid templates

Christian Kuhn CR +2 V +2 Normal +126 −1 updated 11/19/24, 12:07

Commit message

Because of the internal Fluid implementation, Fluid's `render()`
method does not always return a string. If a template only contains
an integer, an integer is returned, if only a ViewHelper is called that
returns an array, an array is returned. Most importantly, empty
template files return `null` instead of an empty string.

For TYPO3's Fluid adapter, this behavior doesn't make sense. Thus,
the result is now cast to string, which prevents PHP errors in the most
common use cases.

Review

  • Code review CR +2 Done
    • Simon Praetorius +2
  • Verified V +2 Done
    • Simon Praetorius +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Christian Kuhn uploaded patch set 1 11/18/24, 19:29

  2. Christian Kuhn voted on patch set 1 CR -1 11/18/24, 19:34

  3. core-ci voted on patch set 1 V +1 11/18/24, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69617

  4. Simon Praetorius uploaded patch set 2 CR -1 V +1 11/19/24, 11:47

  5. core-ci voted on patch set 2 V +1 11/19/24, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69693

  6. Simon Praetorius voted on patch set 2 CR +2 V +2 11/19/24, 12:07

  7. Simon Praetorius merged patch set 3 11/19/24, 12:07