Review main Merged

87040[BUGFIX] Properly resolve flexform schema for record

Oli Bartsch CR +2 V +2 Hard +490 −253 updated 11/19/24, 08:00

Commit message

By using the `FlexFormTools` API, the `FlexFormSchemaFactory`
is now able to properly resolve the flexform schema
for a given record.

This not only handles all kind of use cases, like
default structure, invalid pointer field, etc.
but also improves performance by only resolving
a single flexform schema, depending on the
`dataStructureIdentifier` instead of resolving
all possible structures (looking at the `ds` config)
and matching to the given record afterwards.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/18/24, 19:50

  2. core-ci voted on patch set 1 V +1 11/18/24, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/69620

  3. Christian Kuhn voted on patch set 1 CR +1 V +1 11/18/24, 22:26

  4. Nikita Hovratov voted on patch set 1 CR +1 V +1 11/18/24, 22:37

  5. Oli Bartsch voted on patch set 1 CR +2 V +2 11/19/24, 08:00

  6. Oli Bartsch merged patch set 2 11/19/24, 08:00